Vitals: ClassLoaderDataGraph by SamplerThread is unsynchronized #1442
+29
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unsynchronized
|
Hello @reinrich, I'm sorry, this pull request doesn't meet the expectations. The pull request description has an invalid format. Please have a look at https://github.com/SAP/SapMachine/wiki/Formal-Requirements-of-Pull-Requests . |
|
retest this please |
RealCLanger
approved these changes
Jul 6, 2023
|
Hello @reinrich, this pull request fulfills all formal requirements. |
reinrich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of a04a40b with conflicts.
I think we should do the backport to sapmachine17 because there the cld graph walk is also not sufficiently synchronized.
Conflicts
dec_cld_count()call at the right place.ClassLoaderDataGraph::cld_do, higher versions callClassLoaderDataGraph::loaded_cld_doTesting:
jtreg:test/hotspot/jtreg/runtime/Vitals
gtest:vitals/server
fixes #1438