Allow merging null/optional values #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional OCMF fields like GV should be merged successfully even when their values are null.
sirhcel
force-pushed
the
feature/merge-null-verification-data
branch
from
30ce854
to
7c31cac
Compare
|
Sorry, this commit should have gone on master in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transparency software fails to merge OCMF data where optional fields are not set. For example the gateway firmware version GV. This results in the verification button turning red and giving unknown error/Unbekannter Fehler.
To my understanding, optional fields in OCMF data should be merged just fine. With this patch applied, I could successfully verify example data where GV is not set.