Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vent2 #967

Closed
wants to merge 2 commits into from
Closed

Vent2 #967

wants to merge 2 commits into from

Conversation

PvrG
Copy link
Contributor

@PvrG PvrG commented Dec 1, 2024

Описание PR

Медиа

Тип PR

  • Feature
  • Fix
  • Tweak
  • Balance
  • Refactor
  • Port
  • Translate
  • Resprite

Изменения

Summary by CodeRabbit

Примечания к релизу

  • Новые функции

    • Добавлена возможность управления видимостью вентиляционных труб для игроков, взаимодействующих с механикой ползания по вентиляции.
    • Введены новые компоненты и системы, связанные с ползанием по вентиляции, включая управление состоянием и взаимодействиями с окружающей средой.
    • Расширен каталог с новыми предметами, включая импланты и костюмы, подходящие для ползания по вентиляции.
  • Исправления ошибок

    • Улучшена логика управления состоянием вентиляционных систем, обеспечивая более надежную работу под нагрузкой.
  • Документация

    • Обновлены локализационные файлы для поддержки новых элементов и функций.

@PvrG PvrG requested a review from Rxup as a code owner December 1, 2024 05:38
Copy link
Contributor

coderabbitai bot commented Dec 1, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

В данном пулл-запросе внесены изменения, касающиеся системы управления вентиляцией в игре. Добавлены новые компоненты и классы, связанные с механикой ползания по вентиляции, включая управление видимостью вентиляционных труб и взаимодействие с игроками. Также обновлены существующие классы для интеграции новых функций, таких как управление состоянием энергоснабжения и взаимодействие с объектами, связанными с вентиляцией. Эти изменения расширяют возможности игрового процесса, улучшая управление вентиляционными системами и взаимодействие с ними.

Changes

Файл Изменения
Content.Client/SubFloor/SubFloorHideSystem.cs Добавлено свойство ShowVentPipe для управления видимостью вентиляционных труб. Изменена логика в OnAppearanceChanged для учета нового свойства.
Content.Client/VentCraw/VentCrawVisionSystem.cs Добавлен класс VentCrawSystem, который управляет видимостью вентиляционных труб в зависимости от состояния игрока.
Content.Server/Atmos/Piping/Unary/EntitySystems/GasVentPumpSystem.cs Добавлены зависимости для управления энергоснабжением. Введен метод OnPowerChanged для управления состоянием насоса в зависимости от наличия энергии.
Content.Server/Atmos/Piping/Unary/EntitySystems/GasVentScrubberSystem.cs Добавлены зависимости для управления сварочными компонентами. Введен метод OnWeldChanged для обработки изменений состояния сварки.
Content.Server/VentCraw/BeingVentCrawSystem.cs Добавлен класс BeingVentCrawSystem для управления поведением сущностей, которые могут ползать по вентиляции.
Content.Server/VentCraw/VentCrawClothingSystem.cs Добавлен класс VentCrawClothingSystem для управления взаимодействием между одеждой и механикой ползания по вентиляции.
Content.Server/VentCraw/VentCrawTubeSystem.cs Добавлен класс VentCrawTubeSystem для управления функциональностью вентиляционных труб.
Content.Server/VentCraw/VentCrawableSystem.cs Добавлен класс VentCrawableSystem для управления процессом выхода сущностей из вентиляции.
Content.Shared/Movement/Events/MoveInputEvent.cs Обновлена структура MoveInputEvent, добавлены новые поля Dir и State.
Content.Shared/Movement/Systems/SharedMoverController.Input.cs Обновлены методы для обработки ввода движения с учетом новых параметров.
Content.Shared/VentCraw/Components/BeingVentCrawComponent.cs Добавлен новый компонент BeingVentCrawComponent для обозначения сущностей, ползающих по вентиляции.
Content.Shared/VentCraw/Components/VentCrawBendComponent.cs Добавлен новый компонент VentCrawBendComponent.
Content.Shared/VentCraw/Components/VentCrawClothingComponent.cs Добавлен новый компонент VentCrawClothingComponent.
Content.Shared/VentCraw/Components/VentCrawEntryComponent.cs Добавлен новый компонент VentCrawEntryComponent.
Content.Shared/VentCraw/Components/VentCrawHolderComponent.cs Добавлен новый компонент VentCrawHolderComponent для управления взаимодействием с вентиляцией.
Content.Shared/VentCraw/Components/VentCrawJunctionComponent.cs Добавлен новый компонент VentCrawJunctionComponent.
Content.Shared/VentCraw/Components/VentCrawTransitComponent.cs Добавлен новый компонент VentCrawTransitComponent.
Content.Shared/VentCraw/Components/VentCrawTubeComponent.cs Добавлен новый компонент VentCrawTubeComponent.
Content.Shared/VentCraw/SharedVentCrawableSystem.cs Добавлен класс SharedVentCrawableSystem для управления поведением существ, ползающих по вентиляции.
Content.Shared/VentCraw/SharedVentTubeSystem.cs Добавлен класс SharedVentTubeSystem для управления соединениями между вентиляционными трубами.
Content.Shared/VentCraw/VentCrawlerComponent.cs Добавлен новый компонент VentCrawlerComponent для управления состоянием сущностей в вентиляции.
Resources/Locale/ru-RU/_backmen/Entities/store/uplink-catalog.ftl Добавлены новые записи для локализации, связанные с предметами в каталоге.
Resources/Prototypes/Entities/Clothing/Uniforms/jumpsuits.yml Добавлен новый предмет "Костюм конторциониста" с компонентом VentCrawClothing.
Resources/Prototypes/Entities/Mobs/NPCs/animals.yml Добавлен компонент VentCrawler для нескольких животных.
Resources/Prototypes/Entities/Mobs/NPCs/regalrat.yml Добавлен компонент VentCrawler для MobRatKing и MobRatServant.
Resources/Prototypes/Entities/Mobs/NPCs/slimes.yml Добавлены новые компоненты для различных слизней.
Resources/Prototypes/Entities/Mobs/NPCs/space.yml Добавлены новые сущности и обновлены существующие с учетом новых компонентов.
Resources/Prototypes/Entities/Mobs/NPCs/spacetick.yml Добавлен компонент VentCrawler для space tick.
Resources/Prototypes/Entities/Mobs/NPCs/xeno.yml Добавлены компоненты VentCrawler для burrower и space adder.
Resources/Prototypes/Entities/Structures/Piping/Atmospherics/binary.yml Обновлены сущности для интеграции с системой вентиляции.
Resources/Prototypes/Entities/Structures/Piping/Atmospherics/pipes.yml Добавлены новые сущности и компоненты для системы вентиляции.
Resources/Prototypes/Entities/Structures/Piping/Atmospherics/trinary.yml Обновлены сущности для интеграции с системой вентиляции.
Resources/Prototypes/Entities/Structures/Piping/Atmospherics/unary.yml Обновлены сущности для интеграции с системой вентиляции.
Resources/Prototypes/SoundCollections/vent_clawling.yml Добавлена новая коллекция звуков для механики ползания по вентиляции.
Resources/Prototypes/_Backmen/Catalog/uplink_catalog.yml Добавлены новые записи для каталога.
Resources/Prototypes/_Backmen/Entities/Mobs/NPCs/TGMC_xeno.yml Добавлен компонент VentCrawler для KsenosXenoBase.
Resources/Prototypes/_Backmen/Entities/Mobs/NPCs/flesh_cult.yml Добавлены компоненты VentCrawler для различных существ.
Resources/Prototypes/_Backmen/Entities/Mobs/NPCs/haisenberg.yml Добавлен компонент VentCrawler для MobHaisenberg.
Resources/Prototypes/_Backmen/Entities/Mobs/NPCs/mutants.yml Добавлены новые сущности и компоненты для мутантов.
Resources/Prototypes/_Backmen/Entities/Structures/Atmospherics/supermatter.yml Обновлены сущности для управления суперматерией.

🐇 В норке мы ползём,
Вентиляцию найдём,
С трубами дружим мы,
В мире игры — ура, ура!
🐇✨

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 59 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 2f0bf92 and d4f7082.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 2f0bf92 and d4f7082.

⛔ Files ignored due to path filters (22)
  • Resources/Audio/VentCrawling/crawling1.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling10.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling11.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling12.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling13.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling15.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling16.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling17.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling18.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling19.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling2.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling20.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling21.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling22.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling23.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling24.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling4.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling5.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling6.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling7.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling8.ogg is excluded by !**/*.ogg
  • Resources/Audio/VentCrawling/crawling9.ogg is excluded by !**/*.ogg
📒 Files selected for processing (40)
  • Content.Client/SubFloor/SubFloorHideSystem.cs (4 hunks)
  • Content.Client/VentCraw/VentCrawVisionSystem.cs (1 hunks)
  • Content.Server/Atmos/Piping/Unary/EntitySystems/GasVentPumpSystem.cs (1 hunks)
  • Content.Server/Atmos/Piping/Unary/EntitySystems/GasVentScrubberSystem.cs (1 hunks)
  • Content.Server/VentCraw/BeingVentCrawSystem.cs (1 hunks)
  • Content.Server/VentCraw/VentCrawClothingSystem.cs (1 hunks)
  • Content.Server/VentCraw/VentCrawTubeSystem.cs (1 hunks)
  • Content.Server/VentCraw/VentCrawableSystem.cs (1 hunks)
  • Content.Shared/Movement/Events/MoveInputEvent.cs (1 hunks)
  • Content.Shared/Movement/Systems/SharedMoverController.Input.cs (4 hunks)
  • Content.Shared/VentCraw/Components/BeingVentCrawComponent.cs (1 hunks)
  • Content.Shared/VentCraw/Components/VentCrawBendComponent.cs (1 hunks)
  • Content.Shared/VentCraw/Components/VentCrawClothingComponent.cs (1 hunks)
  • Content.Shared/VentCraw/Components/VentCrawEntryComponent.cs (1 hunks)
  • Content.Shared/VentCraw/Components/VentCrawHolderComponent.cs (1 hunks)
  • Content.Shared/VentCraw/Components/VentCrawJunctionComponent.cs (1 hunks)
  • Content.Shared/VentCraw/Components/VentCrawTransitComponent.cs (1 hunks)
  • Content.Shared/VentCraw/Components/VentCrawTubeComponent.cs (1 hunks)
  • Content.Shared/VentCraw/SharedVentCrawableSystem.cs (1 hunks)
  • Content.Shared/VentCraw/SharedVentTubeSystem.cs (1 hunks)
  • Content.Shared/VentCraw/VentCrawlerComponent.cs (1 hunks)
  • Resources/Locale/ru-RU/_backmen/Entities/store/uplink-catalog.ftl (1 hunks)
  • Resources/Prototypes/Entities/Clothing/Uniforms/jumpsuits.yml (1 hunks)
  • Resources/Prototypes/Entities/Mobs/NPCs/animals.yml (11 hunks)
  • Resources/Prototypes/Entities/Mobs/NPCs/regalrat.yml (2 hunks)
  • Resources/Prototypes/Entities/Mobs/NPCs/slimes.yml (1 hunks)
  • Resources/Prototypes/Entities/Mobs/NPCs/space.yml (1 hunks)
  • Resources/Prototypes/Entities/Mobs/NPCs/spacetick.yml (1 hunks)
  • Resources/Prototypes/Entities/Mobs/NPCs/xeno.yml (2 hunks)
  • Resources/Prototypes/Entities/Structures/Piping/Atmospherics/binary.yml (6 hunks)
  • Resources/Prototypes/Entities/Structures/Piping/Atmospherics/pipes.yml (5 hunks)
  • Resources/Prototypes/Entities/Structures/Piping/Atmospherics/trinary.yml (5 hunks)
  • Resources/Prototypes/Entities/Structures/Piping/Atmospherics/unary.yml (3 hunks)
  • Resources/Prototypes/SoundCollections/vent_clawling.yml (1 hunks)
  • Resources/Prototypes/_Backmen/Catalog/uplink_catalog.yml (1 hunks)
  • Resources/Prototypes/_Backmen/Entities/Mobs/NPCs/TGMC_xeno.yml (1 hunks)
  • Resources/Prototypes/_Backmen/Entities/Mobs/NPCs/flesh_cult.yml (3 hunks)
  • Resources/Prototypes/_Backmen/Entities/Mobs/NPCs/haisenberg.yml (1 hunks)
  • Resources/Prototypes/_Backmen/Entities/Mobs/NPCs/mutants.yml (1 hunks)
  • Resources/Prototypes/_Backmen/Entities/Structures/Atmospherics/supermatter.yml (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added S: Untriaged Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation size/L and removed S: Untriaged labels Dec 1, 2024
@PvrG PvrG closed this Dec 1, 2024
@PvrG PvrG deleted the vent branch December 1, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants