Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tweak] Upstream sync #964

Merged
merged 110 commits into from
Dec 1, 2024
Merged

[Tweak] Upstream sync #964

merged 110 commits into from
Dec 1, 2024

Conversation

Roudenn
Copy link
Collaborator

@Roudenn Roudenn commented Nov 30, 2024

апстриме

🆑 Rouden

  • tweak: Обновление до последней версии Upstream 30.11.2024.

MissKay1994 and others added 30 commits November 20, 2024 03:40
* baby proof the terminal

* Make a couple exceptions for items that you might take with you.

* alwayspoweredlights

* Uncuttable cables since cablecomp is a snowflake construction system

* chairs and vendors

* rerun heisentests

* rerun tests again
* fix starting gear storage

* removal of unused

---------

Co-authored-by: MetalSage <[email protected]>
* Fix grids and docks being culled from display prematurely

* Fix inconsistent disabling of "Undock" buttons

* Add a radar icon to indicate where the controlling console is

* Tidy up math

Remove lots of sketchy transforms-of-transforms, which should have been
as single matrix multiply. Assign proper names to matrices. Remove some
redundant calculations.

* Feedback
* Fix door animations mispredicting if closing is interrupted

On master it will flicker states a little bit partially due to it not being predicted.

Instead we'll just set it straight back to opening (no animation is ever played anyway).

* no log
ensure wires are always cut
* babyproof arrivals shuttle

* always powered lights

* uncuttable cables from terminal PR.

---------

Co-authored-by: slarticodefast <[email protected]>
PJBot and others added 15 commits November 29, 2024 09:47
* rename nitrogen internals crate

* nitrogen internals crate description

* migrate CrateNitrogenInternals ID
* Cleanup `ScrubberControl.xaml.cs`

* Minor cleanups

* Another pile of minor cleanups

* Apply requested changes

* Rename "which" into "bound". Add whitespace after "if"
Adds FTLSmashImmune to nuke prototype to stop it from arrival smashing
Adds a comment in FasterThanLight to indicate where the FTLSmashImmuneComponent is checked

Co-authored-by: aa5g21 <[email protected]>
* adjust min blindness back to 0 when PermanentBlindnessComponent is removed

* mapinit changes

* remove OnRemove, move changes to OnShutdown

* goodbye event

* dependency removal

* final adjustment

---------

Co-authored-by: lunarcomets <luanrcomets2@gmail,com>
* Fixes the TEG airlock on marathon

* Fixes the atmos external airlock on cog
@Roudenn Roudenn requested a review from Rxup as a code owner November 30, 2024 11:27
Copy link
Contributor

coderabbitai bot commented Nov 30, 2024

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

119 files out of 207 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added S: Untriaged size/L Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping. Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation and removed S: Untriaged size/L labels Nov 30, 2024
Copy link
Contributor

github-actions bot commented Nov 30, 2024

RSI Diff Bot; head commit a995ec3 merging into 511c129
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Shoes/Boots/combatboots.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/explorer.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/highheelboots.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/jackboots.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/laceups.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/magboots-advanced.rsi

State Old New Status
equipped-FEET-reptilian Removed
on-equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/magboots-science.rsi

State Old New Status
equipped-FEET-reptilian Removed
on-equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/magboots-syndicate.rsi

State Old New Status
equipped-FEET-reptilian Removed
on-equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/magboots.rsi

State Old New Status
equipped-FEET-reptilian Removed
on-equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/mercboots.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/performer.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/speedboots.rsi

State Old New Status
equipped-FEET-reptilian Removed
on-equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/winterboots.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/winterbootscargo.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/winterbootsengi.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/winterbootsmed.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/winterbootssci.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/winterbootssec.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/winterbootssyndicate.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/winterbootsweb.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Boots/workboots.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Misc/damedaneshoes.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Misc/leather.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Misc/snakeskin.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Misc/tourist.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Specific/chef.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Specific/cult.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Specific/galoshes.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Specific/spaceninja.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Shoes/Specific/swat.rsi

State Old New Status
equipped-FEET-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/atmos.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/atmos_casual.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/bartender.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/bartender_purple.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/brigmedic.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/capformal.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/captain.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/cargotech.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/ce.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/ce_nt.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/ce_syndie.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/ce_turtle.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/centcom_agent.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/centcom_officer.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/centcom_official.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/centcomformal.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/chaplain.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/chef.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/chemistry.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/clown.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/clown_banana.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/cluwne.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/cmo.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/cmo_turtle.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/cossack.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/curator.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/damedaneoutfit.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/deathsquad.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/detective.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/detective_grey.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/engineering.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/engineering_hazard.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/ert_engineer.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/ert_janitor.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/ert_leader.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/ert_medic.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/ert_security.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/familiar_garbs.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/flannel.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/genetics.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/hawaiblack.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/hawaiblue.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/hawaired.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/hawaiyellow.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/hop.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/hos.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/hos_alt.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/hos_blue.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/hos_grey.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/hos_parade.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/hosformal.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/hydro.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/janitor.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/jester.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/jester2.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/journalist.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/kimono.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Resources/Textures/Clothing/Uniforms/Jumpsuit/lawyerblack.rsi

State Old New Status
equipped-INNERCLOTHING-reptilian Removed

Edit: diff updated after a995ec3

@Roudenn Roudenn changed the title Upstream sync [Tweak] Upstream sync Nov 30, 2024
@Rxup Rxup merged commit 2689db9 into Rxup:master Dec 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.