[Fix] no more free chem change for bloba #960

jorgun · 2024-11-28T16:40:24Z

ran into a bug where changing the chem type chud be done whitout paying for it. Now it checks and aborts if you dont have enuf points to do the change.

i cant speak russian so i cant fill this out. sorry

Описание PR

Медиа

Тип PR

Изменения

Summary by CodeRabbit

Новые функции
- Улучшено управление обменом химикатов, теперь проверки выполняются до изменения, что повышает надежность.
- Обновлен интерфейс пользователя для более удобного взаимодействия при выполнении действий обмена химикатов.
Исправления ошибок
- Улучшена обработка ошибок, связанные с действиями наблюдателя за Blob, для повышения устойчивости к ошибкам.

ran into a bug where changing the chem type chud be done whitout paying for it. Now it checks and aborts if you dont have enuf points to do the change.

coderabbitai · 2024-11-28T16:40:32Z

Процесс

Изменения в классе BlobObserverSystem касаются обработки химических замен и управления действиями наблюдателя блоба. В методе OnChemSelected добавлена новая проверка, которая гарантирует, что возможность замены химикатов используется до выполнения изменения. Это изменяет порядок выполнения и обработку ошибок, связанных с заменами химикатов. Метод OnBlobSwapChem теперь включает вызов TryOpenUi, который вызывается без условий при выполнении действия замены. Также обновлены методы OnSplitCore и OnSwapCore, чтобы включать проверки на возможность выполнения конкретных действий.

Изменения

Файл	Изменения
Content.Server/Backmen/Blob/BlobObserverSystem.cs	Обновлены методы `OnChemSelected`, `OnBlobSwapChem`, `OnSplitCore`, `OnSwapCore` с добавлением проверок и изменением логики.

Стихотворение

В норке, где блобы весело скачут,
Химикаты меняются, как в сказке,
Проверки теперь — всегда на страже,
Действия крепче, и нет больше фраже.
Улыбки и радость в каждом обмене,
Блобы танцуют в химическом мгновении! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

Content.Server/Backmen/Blob/BlobObserverSystem.cs (1)
209-212: Проверка стоимости смены химического типа реализована корректно!

Изменение правильно предотвращает бесплатную смену химического типа, проверяя наличие достаточного количества очков перед выполнением действия. Код интегрирован с существующей системой проверки стоимости способностей.

Небольшое предложение по улучшению: добавьте всплывающее сообщение, информирующее игрока о недостатке очков.
 if (!_blobCoreSystem.TryUseAbility(component.Core.Value, blobCoreComponent.SwapChemCost))
+{
+    _popup.PopupEntity(Loc.GetString("blob-insufficient-points", ("cost", blobCoreComponent.SwapChemCost)), 
+        uid, uid, PopupType.LargeCaution);
     return;
+}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5bb99f9 and 7d0adc2.

📒 Files selected for processing (1)

Content.Server/Backmen/Blob/BlobObserverSystem.cs (1 hunks)

voko421 · 2024-11-28T18:09:30Z

erm

Roudenn · 2024-11-28T19:04:11Z

erm

we all love heisentests failurue

Roudenn

Sike, actually there's an issue with the order of if's
Please move points removal just right above the chem swap, so when you click on current chem the system won't steal your points

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

Content.Server/Backmen/Blob/BlobObserverSystem.cs (1)
209-214: Корректная проверка стоимости смены химического типа!

Изменения правильно решают проблему бесплатной смены химического типа. Проверка наличия достаточного количества очков теперь выполняется до изменения типа.

Предлагаю добавить сообщение игроку при недостатке очков:
 if (!_blobCoreSystem.TryUseAbility(component.Core.Value, blobCoreComponent.SwapChemCost))
+{
+    _popup.PopupEntity(Loc.GetString("blob-not-enough-points"), uid, uid, PopupType.LargeCaution);
     return;
+}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7d0adc2 and 3b14429.

📒 Files selected for processing (1)

Content.Server/Backmen/Blob/BlobObserverSystem.cs (1 hunks)

jorgun · 2024-11-28T19:49:14Z

ah yes, i diddnt see that as the Chemical ui select dont let you select the chemical allready selected.
there is stil la problem that it will let you select a new chemical whitout having payed for it, closeing and reopening the menu resets this.

no more free chem change for bloba

7d0adc2

ran into a bug where changing the chem type chud be done whitout paying for it. Now it checks and aborts if you dont have enuf points to do the change.

jorgun requested a review from Rxup as a code owner November 28, 2024 16:40

github-actions bot added size/XS S: Untriaged labels Nov 28, 2024

coderabbitai bot reviewed Nov 28, 2024

View reviewed changes

Roudenn self-requested a review November 28, 2024 18:02

Roudenn approved these changes Nov 28, 2024

View reviewed changes

Roudenn requested changes Nov 28, 2024

View reviewed changes

Update BlobObserverSystem.cs

3b14429

coderabbitai bot reviewed Nov 28, 2024

View reviewed changes

Merge branch 'master' into pr/960

1d16244

Roudenn approved these changes Nov 30, 2024

View reviewed changes

Roudenn changed the title ~~no more free chem change for bloba~~ [Fix] no more free chem change for bloba Nov 30, 2024

Roudenn added Fix Я хочу исправить то что работает не так. Ready2Merge PR готов к внесению в репозиторий. and removed S: Untriaged labels Dec 1, 2024

Rxup merged commit 76712bf into Rxup:master Dec 6, 2024
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix] no more free chem change for bloba #960

[Fix] no more free chem change for bloba #960

jorgun commented Nov 28, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 28, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

voko421 commented Nov 28, 2024

Roudenn commented Nov 28, 2024

Roudenn left a comment

coderabbitai bot left a comment

jorgun commented Nov 28, 2024

[Fix] no more free chem change for bloba #960

[Fix] no more free chem change for bloba #960

Conversation

jorgun commented Nov 28, 2024 • edited by coderabbitai bot Loading

Описание PR

Медиа

Тип PR

Summary by CodeRabbit

coderabbitai bot commented Nov 28, 2024 • edited Loading

Процесс

Изменения

Стихотворение

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

voko421 commented Nov 28, 2024

Roudenn commented Nov 28, 2024

Roudenn left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

jorgun commented Nov 28, 2024

jorgun commented Nov 28, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 28, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)