Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add new wrecks #959

Merged
merged 5 commits into from
Dec 13, 2024
Merged

[FEATURE] Add new wrecks #959

merged 5 commits into from
Dec 13, 2024

Conversation

bazelik-null
Copy link
Contributor

@bazelik-null bazelik-null commented Nov 28, 2024 •
edited by coderabbitai bot
Loading

Описание PR

Добавлены новые большие обломки для утилей. Каждый из них имеет свой небольшой сюжет написанный в записках. Скриншоты записок лежат в ДС https://discord.com/channels/1053200453829132298/1294601213727477841

P.S. Скрин станции немного устарел, но она особо не изменена.

Хранилище в астероиде

Лут:
3 хороших компонента
2 консольные и одна машинная платы
2 скафандра шахтёра и 2 скафандра инженера
2 стака стали
1 MP-5, 1 M16A4, 1 гадюка
1 техфаб патронов
1 артефакт
1 ящик плазмы, 1 ящик электротех, 1 ящик топлива ДАМ
? ресурсы с руды окружающей хранилище
Противники:
1 голокарп
3 космических клеща
1 карпоакула
4 карпа
1 медведь
1 турель

Мини-станция

Лут:
3 аптечки (обычные)
1 древний бронескафандр и древняя EVA
1 консерва с фасолью, 3 мясных консервы, 2 бутылки воды
1 случайный ручной артефакт
1 AR-18
1 изолированные перчатки, 1 инженерные очки, материалы, 1 пояс для инструментов
1 Стимпак-аптечка
Противники:
3 карпа
3 клеща
3 паука (космо)
1 карпоакула
Возможен ремонт, имеются все ресурсы для этого

Медиа

Хранилище в астероиде

image
image

Станция

image
image

Тип PR

  • Feature
  • Fix
  • Tweak
  • Balance
  • Refactor
  • Port
  • Translate
  • Resprite

Изменения

Summary by CodeRabbit

  • Новые функции
    • Добавлены две новые карты для спасения в категории "Большие": MiniSpaceStation и BigStorage.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 28, 2024 •
edited
Loading

Процесс

В данном запросе на изменение добавлены новые записи в файл salvage.yml, в частности, два новых salvage-карты в категории "Большие". Новые записи включают карту с ID MiniSpaceStation и карту с ID BigStorage, обе из которых имеют соответствующие пути и категорию размера. Эти изменения расширяют доступные salvage-карты, не затрагивая существующие записи или их свойства.

Изменения

Файл Изменения
Resources/Prototypes/Maps/salvage.yml Добавлены новые карты: MiniSpaceStation и BigStorage с соответствующими путями и категориями.

Стихотворение

В норке я сижу, карты новые пишу,
МиниКосмостанция, хранилище в пути,
Большие карты в игре, теперь все в порядке,
Скачем по миру, радуемся в сладкой загадке! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added S: Untriaged size/XL Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping. Changes: No C# labels Nov 28, 2024
@bazelik-null bazelik-null marked this pull request as ready for review November 30, 2024 18:26
@bazelik-null bazelik-null requested a review from Rxup as a code owner November 30, 2024 18:26
coderabbitai[bot]
coderabbitai bot reviewed Nov 30, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
Resources/Prototypes/Maps/salvage.yml (1)

181-184: Рассмотрите переименование MiniSpaceStation

Название "Mini" для карты в категории "Large" может вводить в заблуждение. Предлагаю использовать более описательное название, например "AbandonedSpaceStation" или "ResearchStation".

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 511c129 and fd42c2c.

📒 Files selected for processing (1)
  • Resources/Prototypes/Maps/salvage.yml (1 hunks)
🔇 Additional comments (1)
Resources/Prototypes/Maps/salvage.yml (1)

181-189: Проверьте количество сущностей и структуру каталогов

Учитывая большое количество предметов и врагов в новых картах (согласно описанию PR), рекомендуется:

  1. Убедиться, что количество сущностей оптимизировано
  2. Рассмотреть возможность использования процедурной генерации для некоторых элементов
  3. Привести пути к файлам карт в соответствие с существующей структурой /Maps/Salvage/

Resources/Prototypes/Maps/salvage.yml Show resolved Hide resolved
@bazelik-null
Copy link
Contributor Author

@Roudenn
Жду ответа

@Roudenn Roudenn self-requested a review December 1, 2024 05:28
@Roudenn
Copy link
Collaborator

Roudenn commented Dec 1, 2024

Ревью Soon™

@Roudenn Roudenn added No C# Нету кода. Feature Я хочу добавить что-то новое. Require Testing Требуется тестирование! and removed S: Untriaged Changes: No C# labels Dec 1, 2024
@bazelik-null
Copy link
Contributor Author

@Roudenn wake up

@KayzelW KayzelW merged commit d0c5e5d into Rxup:master Dec 13, 2024
12 checks passed
@bazelik-null bazelik-null deleted the salvage branch December 20, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@KayzelW KayzelW KayzelW approved these changes

@Rxup Rxup Awaiting requested review from Rxup Rxup is a code owner

@Roudenn Roudenn Awaiting requested review from Roudenn

Assignees
No one assigned
Labels
Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping. Changes: No C# Feature Я хочу добавить что-то новое. No C# Нету кода. Require Testing Требуется тестирование! size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bazelik-null @Roudenn @KayzelW