Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port] Surgety Update: Outer Content #944

Merged
merged 7 commits into from
Nov 26, 2024
Merged

Conversation

Roudenn
Copy link
Collaborator

@Roudenn Roudenn commented Nov 25, 2024

Порт контента со сборки Goob Station, портировал почти всё что связано с хирургией, даже звуки и спрайты

🆑 Rouden, Mocho, и многие другие

  • tweak: Огромное обновление хирургии. Больше контента, меньше (наверное) багов.

gluesniffler and others added 6 commits November 25, 2024 16:48
* full fucking send

* ope forgot to remove the EE scripts

* fix test

* fix shitcode fail

* DELTA THAT VALUE IS NULLABLE

* whoopsie daysie

* fixed???

* chat is this real
* full fucking send

* ope forgot to remove the EE scripts

* fix test

* fix shitcode fail

* DELTA THAT VALUE IS NULLABLE

* whoopsie daysie

* fixed???
* allow cloning living people

* fix client

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
* Added missing locale strings for limb targeting bindings

* Moved the strings down where the rest of shitmed goes
* full fucking send

* ope forgot to remove the EE scripts

* fix test

* fix shitcode fail

* DELTA THAT VALUE IS NULLABLE

* whoopsie daysie
fixes

add and fix shit
@Roudenn Roudenn requested a review from Rxup as a code owner November 25, 2024 16:12
Copy link
Contributor

coderabbitai bot commented Nov 25, 2024

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

70 files out of 154 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added S: Untriaged Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation and removed S: Untriaged labels Nov 25, 2024
Copy link
Contributor

github-actions bot commented Nov 25, 2024

RSI Diff Bot; head commit 64324e2 merging into 636da48
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Specific/Medical/Surgery/bonesetter.rsi

State Old New Status
bonesetter Modified
inhand-left Added
inhand-right Added

Resources/Textures/Backmen/Mobs/Species/Harpy/organs.rsi

State Old New Status
lung-l Added
lung-r Added

Resources/Textures/Backmen/Mobs/Species/Harpy/parts.rsi

State Old New Status
full Added
head_f Added
head_m Added
l_arm Added
l_foot Added
l_hand Added
l_leg Added
r_arm Added
r_foot Added
r_hand Added
r_leg Added
torso_f Added
torso_m Added

Resources/Textures/Interface/Actions/actions_borg.rsi

State Old New Status
adv-surgery-module Added
surgery-module Added

Resources/Textures/Objects/Specific/Robotics/borgmodule.rsi

State Old New Status
icon-advanced-surgery Added
icon-surgery Added

Resources/Textures/_Shitmed/Mobs/Species/Cybernetics/bishop/bishop_alt1.rsi

State Old New Status
head Added

Resources/Textures/_Shitmed/Mobs/Species/Cybernetics/bishop/bishop_main.rsi

State Old New Status
head Added
l_arm-combined Added
l_arm-primary Added
l_arm-secondary Added
l_arm-tertiary Added
l_foot Added
l_hand Added
l_leg-combined Added
l_leg-primary Added
l_leg-secondary Added
r_arm-combined Added
r_arm-primary Added
r_arm-secondary Added
r_arm-tertiary Added
r_foot Added
r_hand Added
r_leg-combined Added
r_leg-primary Added
r_leg-secondary Added
torso-primary Added
torso-secondary Added

Resources/Textures/_Shitmed/Mobs/Species/Cybernetics/bishop/bishop_monitor.rsi

State Old New Status
head-2 Added
head Added

Resources/Textures/_Shitmed/Mobs/Species/Cybernetics/hesphiastos/hesphiastos_alt1.rsi

State Old New Status
head-1 Added
head-2 Added
head-3 Added

Resources/Textures/_Shitmed/Mobs/Species/Cybernetics/hesphiastos/hesphiastos_main.rsi

State Old New Status
l_arm-1 Added
l_arm-2 Added
l_foot-1 Added
l_foot-2 Added
l_hand-1 Added
l_hand-2 Added
l_leg-1 Added
l_leg-2 Added
r_arm-1 Added
r_arm-2 Added
r_foot-1 Added
r_foot-2 Added
r_hand-1 Added
r_hand-2 Added
r_leg-1 Added
r_leg-2 Added
torso-1 Added
torso-2 Added

Resources/Textures/_Shitmed/Mobs/Species/Cybernetics/hesphiastos/hesphiastos_monitor.rsi

State Old New Status
head-1 Added
head-2 Added

Resources/Textures/_Shitmed/Mobs/Species/Cybernetics/morpheus/morpheus_alt1.rsi

State Old New Status
head Added

Resources/Textures/_Shitmed/Mobs/Species/Cybernetics/morpheus/morpheus_main.rsi

State Old New Status
head Added
l_arm Added
l_foot Added
l_hand Added
l_leg Added
r_arm Added
r_foot Added
r_hand Added
r_leg Added
torso Added

Resources/Textures/_Shitmed/Mobs/Species/Cybernetics/shellguard/shellguard_alt1.rsi

State Old New Status
head-1 Added
head-2 Added

Resources/Textures/_Shitmed/Mobs/Species/Cybernetics/shellguard/shellguard_main.rsi

State Old New Status
l_arm-1 Added
l_arm-2 Added
l_foot-1 Added
l_foot-2 Added
l_hand-1 Added
l_hand-2 Added
l_leg-1 Added
l_leg-2 Added
r_arm-1 Added
r_arm-2 Added
r_foot-1 Added
r_foot-2 Added
r_hand-1 Added
r_hand-2 Added
r_leg-1 Added
r_leg-2 Added
torso-1 Added
torso-2 Added

Resources/Textures/_Shitmed/Mobs/Species/Cybernetics/shellguard/shellguard_monitor.rsi

State Old New Status
head-1 Added
head-2 Added

Resources/Textures/_Shitmed/Mobs/Species/Cybernetics/wardtakahashi/wardtakahashi_alt1.rsi

State Old New Status
head Added

Resources/Textures/_Shitmed/Mobs/Species/Cybernetics/wardtakahashi/wardtakahashi_main.rsi

State Old New Status
head Added
l_arm Added
l_foot Added
l_hand Added
l_leg Added
r_arm Added
r_foot Added
r_hand Added
r_leg Added
torso Added

Resources/Textures/_Shitmed/Mobs/Species/Cybernetics/wardtakahashi/wardtakahashi_monitor.rsi

State Old New Status
head Added

Resources/Textures/_Shitmed/Mobs/Species/Cybernetics/xion/xion_alt1.rsi

State Old New Status
head-1 Added
head-2 Added

Resources/Textures/_Shitmed/Mobs/Species/Cybernetics/xion/xion_main.rsi

State Old New Status
l_arm-1 Added
l_arm-2 Added
l_foot-1 Added
l_foot-2 Added
l_hand-1 Added
l_hand-2 Added
l_leg-1 Added
l_leg-2 Added
r_arm-1 Added
r_arm-2 Added
r_foot-1 Added
r_foot-2 Added
r_hand-1 Added
r_hand-2 Added
r_leg-1 Added
r_leg-2 Added
torso-1 Added
torso-2 Added

Edit: diff updated after 64324e2

@Roudenn Roudenn added the Holy Shit Для очень больших и спорных ПРов. label Nov 25, 2024
@Roudenn
Copy link
Collaborator Author

Roudenn commented Nov 25, 2024

Если хотите подробностей что добавили, то знайте что я сам не до конца уверен что именно, вот настолько там много контента

@Roudenn Roudenn added the Ready2Merge PR готов к внесению в репозиторий. label Nov 25, 2024
@TokenStyle
Copy link
Contributor

Работает? Можно прям щас портировать?

@Roudenn
Copy link
Collaborator Author

Roudenn commented Nov 25, 2024

Работает? Можно прям щас портировать?

Мы понятия не имеем, могут быть неожиданные баги

Уже известны небольшие проблемы, но вот серьезные баги ещё могут найтись

И ещё да, тут есть акцент который полностью рушит РП на серверах где за его уровнем следят

@TokenStyle
Copy link
Contributor

TokenStyle commented Nov 25, 2024

Вот что добавили Goob-Station/Goob-Station#956
Это по меньшей мере, конечно контента много больше:

add: Added different step durations to each surgery step.
add: Added a T2 research for advanced surgical tools
add: Added a T3 research for an omnitool for surgery.
add: Added Surgical and Advanced Surgical modules for Mediborgs
add: Mediborgs can now perform surgery!
add: Added lobotomies as an operation. Godspeed you psychopaths.
add: Added cybernetic arms, legs and eyes.
add: Added EMP weaknesses to all cybernetic parts (the day of reckoning will come for IPCs soon)
add: Losing your eyes now blinds you.
fix: Fixed a few species that did not inherit from BasePart's, thus taking damage types they shouldn't on their limbs.
fix: Fixed harpy lungs not being usable in surgeries.
fix: Fixed fire being able to destroy your chest.
fix: Fixed entities being able to take over your body by just inserting a brain or another head on top of you.
fix: Fixed some shitcode that didnt let rejuvenate or godmode work properly.
fix: Fixed bionic arm, and cybernetic eyes traits not working properly due to shitty networking.
fix: Fixed cybernetic limbs being a free hand/feet generator due to shitcode.
tweak: Increased tend wounds's speed by double, and bumped up the values on its calculations. DEATH TO TOPICALS, LEAVE THOSE TO TIDERS.
tweak: Beheading an entity now doesnt let it move, speak, and forces it to the ground immediately (literally 1984!!11!!)
tweak: Changed sprites on most surgical tools to now use /tg/ sprites.

@Roudenn
Copy link
Collaborator Author

Roudenn commented Nov 25, 2024

Вот что добавили Goob-Station/Goob-Station#956 add: Added different step durations to each surgery step. add: Added a T2 research for advanced surgical tools add: Added a T3 research for an omnitool for surgery. add: Added Surgical and Advanced Surgical modules for Mediborgs add: Mediborgs can now perform surgery! add: Added lobotomies as an operation. Godspeed you psychopaths. add: Added cybernetic arms, legs and eyes. add: Added EMP weaknesses to all cybernetic parts (the day of reckoning will come for IPCs soon) add: Losing your eyes now blinds you. fix: Fixed a few species that did not inherit from BasePart's, thus taking damage types they shouldn't on their limbs. fix: Fixed harpy lungs not being usable in surgeries. fix: Fixed fire being able to destroy your chest. fix: Fixed entities being able to take over your body by just inserting a brain or another head on top of you. fix: Fixed some shitcode that didnt let rejuvenate or godmode work properly. fix: Fixed bionic arm, and cybernetic eyes traits not working properly due to shitty networking. fix: Fixed cybernetic limbs being a free hand/feet generator due to shitcode. tweak: Increased tend wounds's speed by double, and bumped up the values on its calculations. DEATH TO TOPICALS, LEAVE THOSE TO TIDERS. tweak: Beheading an entity now doesnt let it move, speak, and forces it to the ground immediately (literally 1984!!11!!) tweak: Changed sprites on most surgical tools to now use /tg/ sprites.

Там ещё коммиты из пров другие есть, посмотри
И по хорошему это все перевести

@Rxup Rxup merged commit 32f98d3 into Rxup:master Nov 26, 2024
12 checks passed
TokenStyle added a commit to TokenStyle/space-station-14-next that referenced this pull request Nov 26, 2024
From Rxup/space-station-14#944

* Shitmed Update 2 - bottom text (space-syndicate#956)

* full fucking send

* ope forgot to remove the EE scripts

* fix test

* fix shitcode fail

* DELTA THAT VALUE IS NULLABLE

* whoopsie daysie

* fixed???

* chat is this real

* Hotfix for broken organ transplants (space-syndicate#933)

* full fucking send

* ope forgot to remove the EE scripts

* fix test

* fix shitcode fail

* DELTA THAT VALUE IS NULLABLE

* whoopsie daysie

* fixed???

* allow cloning living people (space-syndicate#932)

* allow cloning living people

* fix client

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>

* Added missing locale strings for limb targeting bindings (space-syndicate#921)

* Added missing locale strings for limb targeting bindings

* Moved the strings down where the rest of shitmed goes

* Shitmed Update 1 - Forma de Goob (space-syndicate#897)

* full fucking send

* ope forgot to remove the EE scripts

* fix test

* fix shitcode fail

* DELTA THAT VALUE IS NULLABLE

* whoopsie daysie

* fixes

fixes

add and fix shit

* Fix Harpies

---------

Co-authored-by: gluesniffler <[email protected]>
Co-authored-by: deltanedas <[email protected]>
Co-authored-by: AstroDogeDX <[email protected]>
Co-authored-by: Roudenn <[email protected]>
AwareFoxy pushed a commit to space-syndicate/space-station-14-next that referenced this pull request Nov 26, 2024
* [Feature] They did surgery on a monkey (space-syndicate#927)

Also add faster go sleep when using nitrous oxide (for surgery being better when operating).

* They did surgery on a monkey

* Update animals.yml

* Fix some things

* [Port] Surgery fixes: Diamond Fish (space-syndicate#926)

* хирургия на рыбе

хирургия на рыбе

Co-Authored-By: deltanedas <@deltanedas:kde.org>

* add localization

* kill BreathingImmunity

---------

Co-authored-by: deltanedas <[email protected]>
Co-authored-by: Roudenn <[email protected]>

* Update SurgeryStepDamageChangeEvent.cs (space-syndicate#942)

Namespace renamed properly

---------

Co-authored-by: Trest <[email protected]>

* [Port] Surgety Update: Outer Content

From Rxup/space-station-14#944

* Shitmed Update 2 - bottom text (space-syndicate#956)

* full fucking send

* ope forgot to remove the EE scripts

* fix test

* fix shitcode fail

* DELTA THAT VALUE IS NULLABLE

* whoopsie daysie

* fixed???

* chat is this real

* Hotfix for broken organ transplants (space-syndicate#933)

* full fucking send

* ope forgot to remove the EE scripts

* fix test

* fix shitcode fail

* DELTA THAT VALUE IS NULLABLE

* whoopsie daysie

* fixed???

* allow cloning living people (space-syndicate#932)

* allow cloning living people

* fix client

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>

* Added missing locale strings for limb targeting bindings (space-syndicate#921)

* Added missing locale strings for limb targeting bindings

* Moved the strings down where the rest of shitmed goes

* Shitmed Update 1 - Forma de Goob (space-syndicate#897)

* full fucking send

* ope forgot to remove the EE scripts

* fix test

* fix shitcode fail

* DELTA THAT VALUE IS NULLABLE

* whoopsie daysie

* fixes

fixes

add and fix shit

* Fix Harpies

---------

Co-authored-by: gluesniffler <[email protected]>
Co-authored-by: deltanedas <[email protected]>
Co-authored-by: AstroDogeDX <[email protected]>
Co-authored-by: Roudenn <[email protected]>

* [Port] Surgery fix PartAppearance and other minor fixes (space-syndicate#945)

* fix PartAppearance and bone sawing and keybinds camera

* fix usings code review

* ohio fix for corvax

* Moving everything to _CorvaxNext and some fixes

Fix resomi hand to right arm to hand and left arm to left hand

* add respirator immunity component fix

* localization cybernetics, techs, resomi etc

* let me pass tests pls

* comments names changes

* one more comments name change

* move to right folder

* add missing russian loc file

* add missing russian loc file changes

* let me pass tests plssssss

---------

Co-authored-by: Rouden <[email protected]>
Co-authored-by: deltanedas <[email protected]>
Co-authored-by: Trest <[email protected]>
Co-authored-by: gluesniffler <[email protected]>
Co-authored-by: AstroDogeDX <[email protected]>
@Roudenn Roudenn deleted the surgety-port branch November 30, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Holy Shit Для очень больших и спорных ПРов. Ready2Merge PR готов к внесению в репозиторий.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants