Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resprite tanks #943

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Resprite tanks #943

merged 1 commit into from
Nov 26, 2024

Conversation

voko421
Copy link
Contributor

@voko421 voko421 commented Nov 25, 2024

Описание PR

Респрайт баллонов под ТГ

Тип PR

  • Tweak
  • Resprite

Изменения

🆑

  • tweak: Изменены спрайты баллонов

Summary by CodeRabbit

  • Обновления
    • Обновлены поля авторских прав в метаданных для различных текстур танков, ссылаясь на новый коммит в репозитории tgstation.
    • Изменения касаются текстур: анестетик, экстренный, экстренный двойной, экстренный желтый, общий, кислород, плазма и красный.

@voko421 voko421 requested a review from Rxup as a code owner November 25, 2024 11:52
Copy link
Contributor

coderabbitai bot commented Nov 25, 2024

Walkthrough

В данном запросе на изменение обновлены поля copyright в файлах meta.json для различных ресурсов танков, расположенных в каталоге Resources/Textures/Objects/Tanks/. Все изменения касаются ссылки на разные коммиты в репозитории tgstation. Структура JSON, включая поля version, license, size и states, осталась без изменений.

Changes

Файл Изменения
Resources/Textures/Objects/Tanks/*.rsi/meta.json Обновлено поле copyright на новую ссылку коммита b730d1ab75a4684e4558a3d426dbaa6f103f65f7 из e1142f20f5e4661cb6845cfcf2dd69f864d67432 для следующих файлов:
- anesthetic.rsi
- emergency.rsi
- emergency_double.rsi
- emergency_yellow.rsi
- generic.rsi
- oxygen.rsi
- plasma.rsi
- red.rsi

Poem

В полях танков, где краски ярки,
Мы обновили права, как в сказке,
Ссылки теперь свежи, как утренний свет,
В каждом файле — новый завет!
Пусть танки сияют, как звезды в ночи,
Мы рады изменениям, как в жизни, в мечте! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 636da48 and 3b31df1.

⛔ Files ignored due to path filters (8)
  • Resources/Textures/Objects/Tanks/anesthetic.rsi/icon.png is excluded by !**/*.png
  • Resources/Textures/Objects/Tanks/emergency.rsi/icon.png is excluded by !**/*.png
  • Resources/Textures/Objects/Tanks/emergency_double.rsi/icon.png is excluded by !**/*.png
  • Resources/Textures/Objects/Tanks/emergency_yellow.rsi/icon.png is excluded by !**/*.png
  • Resources/Textures/Objects/Tanks/generic.rsi/icon.png is excluded by !**/*.png
  • Resources/Textures/Objects/Tanks/oxygen.rsi/icon.png is excluded by !**/*.png
  • Resources/Textures/Objects/Tanks/plasma.rsi/icon.png is excluded by !**/*.png
  • Resources/Textures/Objects/Tanks/red.rsi/icon.png is excluded by !**/*.png
📒 Files selected for processing (8)
  • Resources/Textures/Objects/Tanks/anesthetic.rsi/meta.json (1 hunks)
  • Resources/Textures/Objects/Tanks/emergency.rsi/meta.json (1 hunks)
  • Resources/Textures/Objects/Tanks/emergency_double.rsi/meta.json (1 hunks)
  • Resources/Textures/Objects/Tanks/emergency_yellow.rsi/meta.json (1 hunks)
  • Resources/Textures/Objects/Tanks/generic.rsi/meta.json (1 hunks)
  • Resources/Textures/Objects/Tanks/oxygen.rsi/meta.json (1 hunks)
  • Resources/Textures/Objects/Tanks/plasma.rsi/meta.json (1 hunks)
  • Resources/Textures/Objects/Tanks/red.rsi/meta.json (1 hunks)
✅ Files skipped from review due to trivial changes (8)
  • Resources/Textures/Objects/Tanks/anesthetic.rsi/meta.json
  • Resources/Textures/Objects/Tanks/emergency.rsi/meta.json
  • Resources/Textures/Objects/Tanks/emergency_double.rsi/meta.json
  • Resources/Textures/Objects/Tanks/emergency_yellow.rsi/meta.json
  • Resources/Textures/Objects/Tanks/generic.rsi/meta.json
  • Resources/Textures/Objects/Tanks/oxygen.rsi/meta.json
  • Resources/Textures/Objects/Tanks/plasma.rsi/meta.json
  • Resources/Textures/Objects/Tanks/red.rsi/meta.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added S: Untriaged Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: No C# and removed S: Untriaged labels Nov 25, 2024
Copy link
Contributor

RSI Diff Bot; head commit 3b31df1 merging into 636da48
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Tanks/anesthetic.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/emergency.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/emergency_double.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/emergency_yellow.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/generic.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/oxygen.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/plasma.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Tanks/red.rsi

State Old New Status
icon Modified

@Chi-Firka
Copy link

А ревью зачем? Дополнять же нечего

@voko421
Copy link
Contributor Author

voko421 commented Nov 25, 2024

А ревью зачем? Дополнять же нечего

Хз мне лень это отрубать

@Chi-Firka
Copy link

А ревью зачем? Дополнять же нечего

Хз мне лень это отрубать

Справедливо)

@Rxup Rxup requested review from nomad0260 and Kirillcas and removed request for Rxup November 26, 2024 08:27
@KayzelW KayzelW merged commit fece743 into Rxup:master Nov 26, 2024
14 checks passed
@voko421 voko421 deleted the Resprite-tanks branch November 28, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants