Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with translation #938

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Problems with translation #938

merged 1 commit into from
Nov 23, 2024

Conversation

voko421
Copy link
Contributor

@voko421 voko421 commented Nov 23, 2024

Описание PR

Проблемы с переводом, исправил описание до адекватного состояния

Тип PR

  • Feature
  • Fix
  • Tweak
  • Balance
  • Refactor
  • Port
  • Translate
  • Resprite

Изменения

🆑 TedaLover

  • tweak: Изменил описание для ракетной установки LR-5

Summary by CodeRabbit

  • Новые функции
    • Обновлены описания различных видов оружия для улучшения ясности и точности.
    • Изменено описание для ent-WeaponLauncherRL5 с "противоосколочной брони" на "противоброневую ракетную установку".

@voko421 voko421 requested a review from Rxup as a code owner November 23, 2024 20:09
Copy link
Contributor

coderabbitai bot commented Nov 23, 2024

Walkthrough

В данном запросе на изменение обновлены описания различных сущностей оружия в локализационном файле для русского языка. Основные изменения касаются полей .desc для нескольких сущностей, что улучшает ясность и конкретность описаний. Например, описание для ent-WeaponLauncherRL5 было изменено с "противоосколочная броня" на "противоброневая ракетная установка", что более точно отражает назначение оружия. Другие сущности также получили уточнения, однако основные характеристики остались неизменными.

Changes

Файл Изменения
Resources/Locale/ru-RU/ss14-ru/prototypes/backmen/entities/weapons/guns/guns64.ftl Обновлены описания для ent-WeaponLauncherRL5, ent-WeaponSniperMosinAI, ent-WeaponSniperMosinAISniper, ent-WeaponRifleV31 для улучшения ясности и детализации.

Poem

В лесу, где зайцы скачут,
Оружие новое встает,
С описанием ясным,
Как в сказке, что зовет.
Пусть каждый выстрел звучит,
С точностью, что нас манит! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 892e75e and cd7cf8a.

📒 Files selected for processing (1)
  • Resources/Locale/ru-RU/ss14-ru/prototypes/backmen/entities/weapons/guns/guns64.ftl (1 hunks)
🔇 Additional comments (1)
Resources/Locale/ru-RU/ss14-ru/prototypes/backmen/entities/weapons/guns/guns64.ftl (1)

132-132: Улучшено описание RL-5!

Изменение с "противоосколочная броня" на "противоброневая ракетная установка" более точно отражает назначение оружия, так как RL-5 является ракетной установкой, предназначенной для поражения бронированных целей.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@voko421
Copy link
Contributor Author

voko421 commented Nov 23, 2024

ПР который все заслужили

@github-actions github-actions bot added Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: No C# labels Nov 23, 2024
@Rxup Rxup merged commit 555c6cd into Rxup:master Nov 23, 2024
12 checks passed
@voko421 voko421 deleted the Translator-playing branch November 25, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: No C# S: Untriaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants