Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Surgery Hotfix: Head and Limbs dissapears #932

Merged
merged 9 commits into from
Nov 23, 2024
Merged

[Fix] Surgery Hotfix: Head and Limbs dissapears #932

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6539d88
fix dissapearing head and limbs
TokenStyle Nov 22, 2024
eff3dc9
revert hotfix for normal fix
TokenStyle Nov 22, 2024
c2d19a1
Fix limbs being gibbable and let head drop brain, eyes etc
TokenStyle Nov 22, 2024
586245a
cannot fix without more health workaround
TokenStyle Nov 22, 2024
500359d
proper limb fix when destroyed on body to drop organs
TokenStyle Nov 23, 2024
0bdb683
easier to cut off limbs
TokenStyle Nov 23, 2024
e7aa14b
remove unnesseccery edits
TokenStyle Nov 23, 2024
88e8890
easier to cutt off limbs2
TokenStyle Nov 23, 2024
a6d335a
remove unnecessery edits
TokenStyle Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Resources/Prototypes/Body/Parts/base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,19 @@
- trigger:
!type:DamageTypeTrigger
damageType: Blunt
damage: 75
damage: 150 # was 75 . TODO gettin dissapear if lower than dettach health
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Consider proper fix instead of threshold workaround

The TODO comments suggest that increasing damage thresholds is a workaround to prevent parts from disappearing. This might mask the underlying issue where parts are destroyed before they can properly detach.

Consider investigating:

  1. The order of operations between detachment and destruction
  2. Whether detachment should be triggered before reaching destruction thresholds
  3. Implementing a proper state machine for part damage -> detachment -> destruction

Also applies to: 39-39, 45-45

behaviors:
- !type:GibPartBehavior { }
- trigger:
!type:DamageTypeTrigger
damageType: Slash
damage: 100
damage: 200 # was 100 . TODO gettin dissapear if lower than dettach health
behaviors:
- !type:GibPartBehavior { }
- trigger:
!type:DamageTypeTrigger
damageType: Heat
damage: 200
damage: 400 # was 200 . TODO gettin dissapear if lower than dettach health
behaviors:
- !type:SpawnEntitiesBehavior
spawnInContainer: true
Expand Down
Loading