Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tweak] Upstream sync #917

Merged
merged 69 commits into from
Nov 12, 2024
Merged

[Tweak] Upstream sync #917

merged 69 commits into from
Nov 12, 2024

Conversation

Roudenn
Copy link
Collaborator

@Roudenn Roudenn commented Nov 12, 2024

Крутой апстрим

Лавовый биом экспедиций наконец-то исправлен! (наверное?)

🆑

  • add: Upstream sync 12.11.2024

Jezithyr and others added 30 commits October 12, 2024 22:21
It's simple. We kill the heisentest
It's simple. We kill the heisentest
* Fix some rounds failing to end due to mind roles

Fixes #32791

This is caused by ShowRoundEndScoreboard running into a bug trying to display antags: some player is showing up as antag with MindIsAntagonist(), but has no antag roles listed in MindGetAllRoleInfo().

This was caused by one of the roles of the player having the Antag boolean set, but having no AntagPrototype set.

The responsible mind role appeared to be MindRoleSubvertedSilicon which is missing a set for the SubvertedSilicon antag prototype.

I also added resilience to the round-end code to make it so that an exception showing the scoreboard (and sending the Discord message) would not cause the round end logic to completely abort from an exception.

I am planning to add an integration test to cover this bug (no prototype in mind roles), but I'll leave that for not-the-immediate-hotfix.

* At least one maintainer approved this tiny PR without reading it, not naming names.
Fix tech anomaly nexttimer (#32805)

Co-authored-by: metalgearsloth <[email protected]>
* fix ninja bomb component check

* remove TryGetRole
Fix: Plushies no longer delete items when recycled (#32838)

fix

Co-authored-by: beck-thompson <[email protected]>
Update submodule

This fixes an important memory leak.
…tem. (#32942)

Fix loneop spawnrate by reverting it to not use the custom shuttle event system.
* Add debug messages to traitor activation

* more debug
* Initial commit

* Review feedback changes

* ProtoId

* TempCommit

* First attempt to have client alerts

* Review changes
* jumpsuit detailening

* jumpskirt stuff

* meta.json

* update meta.json

* meta.json fix fix

* meta.json fix fix fix
* init

* cleanup

* Oops! Forgot something

* addressing changes

* guh

* guh 2.0

* some cleanup

* all bless the intellicard

* Yippee

* small locale thing

* changes + small bugfix

---------

Co-authored-by: slarticodefast <[email protected]>
lastPechkin and others added 23 commits November 10, 2024 17:40
* Sec Shell Gun Craftability Hotfix

* Capital Fix
Add a check to see the APC is powered before turning the emitter on.
* improve BiomeDunGen

* forgot lol

* Update DungeonJob.PostGenBiome.cs

* Update DungeonJob.PostGenBiome.cs
* Make droppers respect closed/sealed

* Combine nested

* Optimize conditions a bit
@Roudenn Roudenn requested a review from Rxup as a code owner November 12, 2024 17:07
@github-actions github-actions bot added Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping. Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation labels Nov 12, 2024
Copy link
Contributor

github-actions bot commented Nov 12, 2024

RSI Diff Bot; head commit 203e31c merging into aa350c0
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Back/Backpacks/captain.rsi

State Old New Status
equipped-BACKPACK Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Clothing/Back/Duffels/captain.rsi

State Old New Status
equipped-BACKPACK Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Clothing/Back/Satchels/captain.rsi

State Old New Status
equipped-BACKPACK Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Clothing/Hands/Gloves/captain.rsi

State Old New Status
inhand-left Modified
inhand-right Modified

Resources/Textures/Clothing/Head/Hardsuits/capspace.rsi

State Old New Status
equipped-HELMET-vox Modified

Resources/Textures/Clothing/Head/Hats/capcap.rsi

State Old New Status
equipped-HELMET-hamster Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Clothing/Head/Hats/captain.rsi

State Old New Status
equipped-HELMET-hamster Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Clothing/Mask/gascaptain.rsi

State Old New Status
equipped-MASK-reptilian Modified
equipped-MASK-vox Modified
equipped-MASK Modified
icon Modified

Resources/Textures/Clothing/OuterClothing/Armor/captain_carapace.rsi

State Old New Status
equipped-OUTERCLOTHING-vox Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Clothing/OuterClothing/Hardsuits/capspace.rsi

State Old New Status
equipped-OUTERCLOTHING-vox Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Clothing/OuterClothing/WinterCoats/coat.rsi

State Old New Status
CAP-equipped-OUTERCLOTHING-vox Modified
CAP-inhand-left Modified
CAP-inhand-right Modified

Resources/Textures/Clothing/Uniforms/Jumpskirt/capformaldress.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Modified
equipped-INNERCLOTHING Modified
icon Modified
inhand-left Modified
inhand-right Modified
equipped-INNERCLOTHING-reptilian Added

Resources/Textures/Clothing/Uniforms/Jumpskirt/captain.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/Clothing/Uniforms/Jumpskirt/color.rsi

State Old New Status
equipped-INNERCLOTHING Modified
icon Modified
inhand-left Modified
inhand-right Modified
prisoner-inhand-left Modified
prisoner-inhand-right Modified
trinkets-equipped-INNERCLOTHING Modified

Resources/Textures/Clothing/Uniforms/Jumpsuit/color.rsi

State Old New Status
equipped-INNERCLOTHING Modified
icon Modified
inhand-left Modified
inhand-right Modified
prisoner-equipped-INNERCLOTHING Modified
prisoner-icon Modified
prisoner-inhand-left Modified
trinkets-equipped-INNERCLOTHING Modified
trinkets-icon Modified
trinkets-inhand-left Modified
trinkets-inhand-right Modified

Resources/Textures/Interface/Alerts/walking.rsi

State Old New Status
walking Added

Edit: diff updated after 203e31c

@Rxup Rxup merged commit d318b2e into Rxup:master Nov 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.