Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resprite] Centcom security items #884

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

Agronomist-NN
Copy link
Contributor

@Agronomist-NN Agronomist-NN commented Nov 2, 2024

Описание PR

Данный PR добавляет респрайт комбинезона приватного офицера ЦК а также новые вещи для СБ ЦК. В список новых вещей входит: новый шлем для СБ ЦК, новый рюкзак в расцветке ЦК, подкованные сапоги в цветах ЦК, бронежилет СБ ЦК. Так же был изменён супер пояс СБ, теперь он имеет зелёную плашку а не красную. Стартинггиры главы СБ ЦК и приватного офицера были изменен в соответствии с новым набором предметов.

Медиа

image

Тип PR

  • Resprite
  • Feature
  • Fix
  • Tweak
  • Balance
  • Refactor
  • Port
  • Translate

Изменения
🆑

  • fix: Спрайт приватного офицера ЦК был улучшен и добавлен в startingGear.
  • add: Добавлен шлем службы безопасности Центком.
  • add: Добавлены подкованные сапоги Центком.
  • add: Добавлен рюкзак Центком (РЮКЗАК ЗЕЛЁНЫХ ЧЕЛОВЕЧКОВ!!!).
  • add: Добавлен бронежилет Центком.
  • add: ClothingBeltSecuritySuper AND ClothingBeltSecurityCentComSecurity (один маленький красный пиксель заменён на один маленький зелёный пиксель).
  • fix: В startingGear'ы начальника безопасности ЦК и приватного офицера были внесены новые предметы указанные в данном чейндж-логе.

- A jumpsuit was redrawn for a private officer of the Central Command.

- A Centcom backpack has been added.

- Boots for Centcom employees were added.

- A bulletproof vest in Centcom colors was added.

- ClothingBeltSecuritySuper AND ClothingBeltSecurityCentComSecurity got a new sprite.

- A Central Command security helmet has been added.

- StartingGears for Centcom HoS and private officer were changed. Now they have new Centcom items with them.
@Agronomist-NN Agronomist-NN requested a review from Rxup as a code owner November 2, 2024 12:46
@github-actions github-actions bot added Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# Нету кода. labels Nov 2, 2024
Copy link
Contributor

github-actions bot commented Nov 2, 2024

RSI Diff Bot; head commit 5e23bae merging into 3921468
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Backmen/Clothing/Uniforms/jumpsuit/centcom-private_officer.rsi

State Old New Status
equipped-INNERCLOTHING Modified
icon Modified
inhand-left Modified
inhand-right Modified
equipped-INNERCLOTHING-reptilian Added

Resources/Textures/Backmen/Clothing/Back/Backpacks/centcom_backpack.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Backmen/Clothing/Belt/centcom_security_belt.rsi

State Old New Status
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Backmen/Clothing/Head/Helmets/centcom_sec_helmet.rsi

State Old New Status
equipped-HELMET-vox Added
equipped-HELMET Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Backmen/Clothing/OuterClothing/Armor/centcom_sec_armor.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Backmen/Clothing/Shoes/Boots/centcom_jackboots.rsi

State Old New Status
equipped-FEET-digi Added
equipped-FEET Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after 5e23bae

trest100
trest100 previously approved these changes Nov 2, 2024
@nomad0260 nomad0260 self-requested a review November 2, 2024 13:02
@nomad0260 nomad0260 dismissed trest100’s stale review November 2, 2024 13:04

апровал гавна

@@ -59,13 +59,13 @@
id: HeadOfSecurityCentComGear
equipment:
jumpsuit: ClothingUniformJumpsuitCentcomMilitary
back: ClothingBackpackSecurity
shoes: ClothingShoesBootsNedoSpetsnaz
back: ClothingCentcomBackpackMilitaryFilled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

замени филл айтемы, посмотри https://github.com/Rxup/space-station-14/blob/master/Resources/Prototypes/Roles/Jobs/CentComm/cburn.yml
в сторадж засунь, не делая нового айди

- type: StorageFill
contents:
- id: MedkitCombatFilled
- id: BoxSurvivalSecurity
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это должно быть в лодаутах, смотри


"SurvivalSecurity" в лодаут засунь

@nomad0260 nomad0260 changed the title Centcom security items [Resprite] Centcom security items Nov 2, 2024
@Rxup Rxup merged commit 1c9b01e into Rxup:master Nov 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# Нету кода.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants