Sanek31 portable camera monitor #820
Conversation
github-actions
bot
added
Changes: Sprites
There was a problem hiding this comment.
Unhandled exception. System.AggregateException: One or more errors occurred. (One or more errors occurred. (CLIENT: 12,773s [ERRO] proto: Reading Robust.Shared.Prototypes.EntityPrototype(HandHeldCameras) threw the following exception: System.ArgumentException: No mapping or value node provided for type System.Collections.Generic.Dictionary`2[System.Enum,Robust.Shared.GameObjects.InterfaceData].
|
У санька получиться. |
github-actions
bot
added
the
Changes: Localization
|
есть что по изменению спрайта? |
такой сойдет? За основу взял синдикатовскую. |
|
|
|
У него получиться. |
|
Целый месяц - трудяга. |
|
КХМ... "пиво" в сторонку! так...
синдикатовский слишком мал, ведь он чёрт возьми шпионский, тут же не должно быть такого параметра, если уж... мне тут один спрайтер в окно стучится с просьбами, поэтому скорее всего его попрошу |
WIP moment |
|
Предлагаю взять вариант с SR. |
|
Но перерисовать. |
WalkthroughЭтот запрос на изменение вносит несколько изменений в различные файлы для улучшения локализации и функциональности портативных камер в системе. В файл локализации на русском языке добавлены новые записи, включая описания для портативных камер. Конфигурация работы надзирателя обновлена, чтобы включить портативные камеры в его стартовое снаряжение. Кроме того, в YAML-конфигурации для портативных компьютеров определены новые сущности, связанные с портативными камерами, и создан файл метаданных JSON для монитора портативной камеры, описывающий его рабочие состояния и информацию о лицензировании. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Warden
participant HandHeldCameras
participant Localization
User->>Warden: Начать работу
Warden->>HandHeldCameras: Оснастить HandHeldCameras
HandHeldCameras-->>Warden: Обеспечить возможности мониторинга
Warden->>Localization: Получить русские описания
Localization-->>Warden: Вернуть локализованные термины
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (3)
Resources/Prototypes/Roles/Jobs/Security/warden.yml (1)
43-43: LGTM! Consider documenting the gameplay impact.The addition of HandHeldCameras to the warden's starting gear is properly formatted and aligns with the PR's objective. This change gives wardens surveillance capabilities from the start, which seems appropriate for their security role.
Consider documenting this gameplay change in the appropriate design/balance documentation to help maintain game balance history.
Resources/Prototypes/_Backmen/Entities/Tools/portable_computers.yml (2)
1-5: Fix grammatical errors in the descriptionThe description contains grammatical errors. Consider revising it for better clarity.
- description: The ability to monitoring discreetly anywhere and anytime, just in your pocket. + description: The ability to monitor discreetly anywhere and anytime, right from your pocket.
46-63: Fix YAML formatting issuesThere are several formatting inconsistencies in the file:
- Incorrect indentation levels
- Trailing spaces
- Missing newline at end of file
Apply these formatting fixes:
- type: Sprite sprite: Backmen/Objects/Tools/handheld_camera_monitor.rsi state: icon layers: - - state: off - - state: on + - state: off + - state: on shader: unshaded visible: false - map: [ "enum.PowerDeviceVisualLayers.Powered" ] + map: [ "enum.PowerDeviceVisualLayers.Powered" ] +🧰 Tools
🪛 yamllint (1.29.0-1)
[warning] 59-59: wrong indentation: expected 4 but found 6
(indentation)
[error] 63-63: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (2)
Resources/Textures/Backmen/Objects/Tools/handheld_camera_monitor.rsi/off.pngis excluded by!**/*.pngResources/Textures/Backmen/Objects/Tools/handheld_camera_monitor.rsi/on.pngis excluded by!**/*.png
📒 Files selected for processing (4)
Resources/Locale/ru-RU/backmen/prototypes/Objects/devices/portable_computers.ftl(1 hunks)Resources/Prototypes/Roles/Jobs/Security/warden.yml(1 hunks)Resources/Prototypes/_Backmen/Entities/Tools/portable_computers.yml(1 hunks)Resources/Textures/Backmen/Objects/Tools/handheld_camera_monitor.rsi/meta.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- Resources/Textures/Backmen/Objects/Tools/handheld_camera_monitor.rsi/meta.json
🧰 Additional context used
🪛 yamllint (1.29.0-1)
Resources/Prototypes/_Backmen/Entities/Tools/portable_computers.yml
[warning] 14-14: wrong indentation: expected 4 but found 6
(indentation)
[warning] 35-35: wrong indentation: expected 6 but found 8
(indentation)
[error] 45-45: trailing spaces
(trailing-spaces)
[warning] 59-59: wrong indentation: expected 4 but found 6
(indentation)
[error] 63-63: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (5)
Resources/Locale/ru-RU/backmen/prototypes/Objects/devices/portable_computers.ftl (2)
3-5: LGTM! Correct reference implementation and proper grammar
The empty state entity correctly references the main entity's properties and uses proper Russian grammar for the suffix.
1-5: Verify integration with related configuration files
Let's ensure these localization entries properly match the entity IDs defined in the configuration files.
✅ Verification successful
Entity IDs and integrations are properly configured
The verification shows that:
- Entity IDs
HandHeldCamerasandHandHeldCamerasEmptyare correctly defined inResources/Prototypes/_Backmen/Entities/Tools/portable_computers.yml - The warden's starting gear includes
HandHeldCamerasinResources/Prototypes/Roles/Jobs/Security/warden.yml - The localization entries match the entity IDs and follow the proper inheritance pattern
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify entity IDs match across configuration files
# Check for entity definitions in YAML files
echo "Checking entity definitions in YAML files..."
rg -A 5 "HandHeldCameras" "Resources/Prototypes"
# Check for other references to these entities
echo "Checking for other references to these entities..."
rg -A 5 "ent-HandHeldCameras" "Resources"
Length of output: 2222
Resources/Prototypes/Roles/Jobs/Security/warden.yml (1)
43-43: Verify the HandHeldCameras entity exists
The addition looks syntactically correct, but let's verify that the HandHeldCameras entity is properly defined.
✅ Verification successful
HandHeldCameras entity is properly defined
The entity exists and is properly defined in Resources/Prototypes/_Backmen/Entities/Tools/portable_computers.yml with all necessary components including power management, UI interfaces, and network connectivity for surveillance functionality.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for HandHeldCameras entity definition
rg -l "HandHeldCameras" --type yaml
Length of output: 155
Script:
#!/bin/bash
# Check the content of the file defining HandHeldCameras
cat Resources/Prototypes/_Backmen/Entities/Tools/portable_computers.yml
Length of output: 1825
Resources/Prototypes/_Backmen/Entities/Tools/portable_computers.yml (2)
11-17: Verify sprite asset availability
Ensure that the referenced sprite file exists with all required states.
✅ Verification successful
Sprite assets verified and available
The sprite file handheld_camera_monitor.rsi exists at the correct location and contains both required states "on" and "off" that are referenced in the YAML configuration.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if the sprite file exists and contains required states
fd "handheld_camera_monitor.rsi" Resources/Textures/Backmen/Objects/Tools/
# If found, check for required states in meta.json
if [ $? -eq 0 ]; then
cat Resources/Textures/Backmen/Objects/Tools/handheld_camera_monitor.rsi/meta.json | jq '.states[] | .name'
fi
Length of output: 283
🧰 Tools
🪛 yamllint (1.29.0-1)
[warning] 14-14: wrong indentation: expected 4 but found 6
(indentation)
25-28: Review power consumption settings
The current power consumption rate (100) seems quite high and might drain power cells too quickly. Consider adjusting these values based on intended usage duration.
✅ Verification successful
Power consumption settings are within normal range
The power consumption settings (drawRate: 3, useRate: 100) are consistent with similar devices in the codebase:
- Base handheld devices use useRate: 20
- Medical defibrillator uses useRate: 100
- Other handheld tools like scanners have drawRates between 1-3
The current configuration aligns with established patterns for powered equipment, particularly for devices requiring active power usage.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for similar devices' power consumption for comparison
rg "drawRate|useRate" --type yaml
Length of output: 2478
Resources/Locale/ru-RU/backmen/prototypes/Objects/devices/portable_computers.ftl
Outdated
Show resolved
Hide resolved
| - type: SurveillanceCameraMonitor | ||
| - type: DeviceNetwork | ||
| deviceNetId: Wired | ||
| receiveFrequencyId: SurveillanceCamera | ||
| transmitFrequencyId: SurveillanceCamera | ||
| - type: WiredNetworkConnection |
There was a problem hiding this comment.
Consider adding access restrictions for surveillance data
As this is intended for warden use, consider implementing access restrictions to prevent unauthorized users from accessing surveillance data through the device network.
Consider adding:
- Access level checks in the
SurveillanceCameraMonitorcomponent - Encryption for network transmission
- Authentication requirements for device network access
…able_computers.ftl Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Портативный монитор камер для вардена
Summary by CodeRabbit
Примечания к выпуску
Новые функции
Документация