Skip to content

Commit

Permalink
Update RxSwift for Carthage and share non-iOS schemes as well
Browse files Browse the repository at this point in the history
  • Loading branch information
solidcell committed Mar 6, 2018
1 parent 30aac4e commit 21d24a4
Show file tree
Hide file tree
Showing 16 changed files with 395 additions and 48 deletions.
13 changes: 11 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,15 @@ All notable changes to this project will be documented in this file.

---

## [master](https://github.com/RxSwiftCommunity/RxSwiftUtilities/tree/master) (Xcode 8 / Swift 3.0 compatible)
## [master](https://github.com/RxSwiftCommunity/RxSwiftUtilities/tree/master) (Xcode 9 / Swift 4 compatible)

*nothing*
* nothing *

## [2.0.1](https://github.com/RxSwiftCommunity/RxSwiftUtilities/releases/tag/2.0.1) (Xcode 9 / Swift 4 compatible)

* Update to Swift 4
* Update to RxSwift 4

## [1.0.1](https://github.com/RxSwiftCommunity/RxSwiftUtilities/releases/tag/1.0.1) (Xcode 8 / Swift 3 compatible)

* Initial project with ActivityIndicator
2 changes: 1 addition & 1 deletion Cartfile
Original file line number Diff line number Diff line change
@@ -1 +1 @@
github "ReactiveX/RxSwift" ~> 3.0
github "ReactiveX/RxSwift" ~> 4.0
2 changes: 1 addition & 1 deletion Cartfile.resolved
Original file line number Diff line number Diff line change
@@ -1 +1 @@
github "ReactiveX/RxSwift" "3.0.1"
github "ReactiveX/RxSwift" "4.1.2"
16 changes: 15 additions & 1 deletion ExampleApp/ExampleApp.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
isa = PBXProject;
attributes = {
LastSwiftUpdateCheck = 0800;
LastUpgradeCheck = 0800;
LastUpgradeCheck = 0920;
ORGANIZATIONNAME = RxSwiftCommunity;
TargetAttributes = {
888CC1F81DE494BB00DAE48A = {
Expand Down Expand Up @@ -262,15 +262,22 @@
CLANG_CXX_LIBRARY = "libc++";
CLANG_ENABLE_MODULES = YES;
CLANG_ENABLE_OBJC_ARC = YES;
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
CLANG_WARN_BOOL_CONVERSION = YES;
CLANG_WARN_COMMA = YES;
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_SUSPICIOUS_MOVES = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
Expand Down Expand Up @@ -311,15 +318,22 @@
CLANG_CXX_LIBRARY = "libc++";
CLANG_ENABLE_MODULES = YES;
CLANG_ENABLE_OBJC_ARC = YES;
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
CLANG_WARN_BOOL_CONVERSION = YES;
CLANG_WARN_COMMA = YES;
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_SUSPICIOUS_MOVES = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
Expand Down
8 changes: 4 additions & 4 deletions ExampleApp/ExampleApp/ActivityIndicatorViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -30,24 +30,24 @@ class ActivityIndicatorViewController: UITableViewController {
[switch1, switch2, switch3].forEach { switchControl in
createActivityObservable(switchControl: switchControl, activityIndicator: activityIndicator)
.subscribe()
.addDisposableTo(disposeBag)
.disposed(by: disposeBag)
}

// This will drive the UILabel in the view controller
activityIndicator.asDriver()
.map { String(describing: $0) }
.drive(valueCell.textLabel!.rx.text)
.addDisposableTo(disposeBag)
.disposed(by: disposeBag)

// This will drive a UIActivityIndicatorView in the view controller
activityIndicator.asDriver()
.drive(activityIndicatorView.rx.isAnimating)
.addDisposableTo(disposeBag)
.disposed(by: disposeBag)

// This will drive the Network Activity Indicator in the status bar
activityIndicator.asDriver()
.drive(UIApplication.shared.rx.isNetworkActivityIndicatorVisible)
.addDisposableTo(disposeBag)
.disposed(by: disposeBag)
}

private func createActivityObservable(switchControl: UISwitch,
Expand Down
48 changes: 31 additions & 17 deletions ExampleApp/ExampleApp/Base.lproj/Main.storyboard

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions ExampleApp/Podfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '10.0'
use_frameworks!

target "ExampleApp" do
Expand Down
2 changes: 1 addition & 1 deletion ExampleApp/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ SPEC CHECKSUMS:
RxSwift: e49536837d9901277638493ea537394d4b55f570
RxSwiftUtilities: b292dcdc286744db591fea3146c9382abc6e0033

PODFILE CHECKSUM: 7684ee7ca38232e18d184c27a385894b625d7ee4
PODFILE CHECKSUM: 76bf4791be77375ab3f65b32b122237d1e9eaf79

COCOAPODS: 1.4.0
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ let signedIn = loginButtonTap.withLatestFrom(usernameAndPassword)

signingIn.asDriver()
.drive(UIApplication.shared.rx.isNetworkActivityIndicatorVisible)
.addDisposableTo(disposeBag)
.disposed(by: disposeBag)
```

## Example App
Expand All @@ -46,8 +46,8 @@ Open the project located in [`ExampleApp/`](ExampleApp/) with Xcode and build/ru

## Requirements

* Xcode 8.0
* Swift 3.0
* Xcode 9
* Swift 4

## Installation

Expand Down
3 changes: 2 additions & 1 deletion RxSwiftUtilities.podspec
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
Pod::Spec.new do |s|
s.name = "RxSwiftUtilities"
s.version = "2.0.0"
s.version = "2.0.1"
s.summary = "Helpful classes and extensions for RxSwift"
s.description = <<-DESC
Helpful classes and extensions for RxSwift which don't belong in RxSwift core.
DESC
s.homepage = "https://github.com/RxSwiftCommunity/RxSwiftUtilities"
s.license = { :type => "MIT", :file => "LICENSE.md" }
s.author = { "Jesse Farless" => "[email protected]" }
s.swift_version = "4.0"
s.ios.deployment_target = "8.0"
s.osx.deployment_target = "10.10"
s.tvos.deployment_target = "9.0"
Expand Down
52 changes: 36 additions & 16 deletions RxSwiftUtilities.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -430,36 +430,42 @@
isa = PBXProject;
attributes = {
LastSwiftUpdateCheck = 0800;
LastUpgradeCheck = 0800;
LastUpgradeCheck = 0920;
ORGANIZATIONNAME = RxSwiftCommunity;
TargetAttributes = {
880343071DE303160055DA33 = {
CreatedOnToolsVersion = 8.0;
LastSwiftMigration = 0800;
LastSwiftMigration = 0920;
ProvisioningStyle = Automatic;
};
880343101DE303160055DA33 = {
CreatedOnToolsVersion = 8.0;
LastSwiftMigration = 0920;
ProvisioningStyle = Automatic;
};
888CC19F1DE48A1000DAE48A = {
CreatedOnToolsVersion = 8.0;
LastSwiftMigration = 0920;
ProvisioningStyle = Automatic;
};
888CC1A71DE48A1000DAE48A = {
CreatedOnToolsVersion = 8.0;
LastSwiftMigration = 0920;
ProvisioningStyle = Automatic;
};
888CC1CB1DE48E9000DAE48A = {
CreatedOnToolsVersion = 8.0;
LastSwiftMigration = 0920;
ProvisioningStyle = Automatic;
};
888CC1D31DE48E9100DAE48A = {
CreatedOnToolsVersion = 8.0;
LastSwiftMigration = 0920;
ProvisioningStyle = Automatic;
};
88E73C601DE481A100C0D2F6 = {
CreatedOnToolsVersion = 8.0;
LastSwiftMigration = 0920;
ProvisioningStyle = Automatic;
};
};
Expand Down Expand Up @@ -677,15 +683,22 @@
CLANG_CXX_LIBRARY = "libc++";
CLANG_ENABLE_MODULES = YES;
CLANG_ENABLE_OBJC_ARC = YES;
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
CLANG_WARN_BOOL_CONVERSION = YES;
CLANG_WARN_COMMA = YES;
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_SUSPICIOUS_MOVES = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
Expand Down Expand Up @@ -731,15 +744,22 @@
CLANG_CXX_LIBRARY = "libc++";
CLANG_ENABLE_MODULES = YES;
CLANG_ENABLE_OBJC_ARC = YES;
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
CLANG_WARN_BOOL_CONVERSION = YES;
CLANG_WARN_COMMA = YES;
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_SUSPICIOUS_MOVES = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
Expand Down Expand Up @@ -790,7 +810,7 @@
PRODUCT_NAME = RxSwiftUtilities;
SKIP_INSTALL = YES;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.0;
};
name = Debug;
};
Expand All @@ -814,7 +834,7 @@
PRODUCT_BUNDLE_IDENTIFIER = com.RxSwiftCommunity.RxSwiftUtilities;
PRODUCT_NAME = RxSwiftUtilities;
SKIP_INSTALL = YES;
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.0;
};
name = Release;
};
Expand All @@ -830,7 +850,7 @@
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.RxSwiftCommunity.RxSwiftUtilitiesTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.0;
};
name = Debug;
};
Expand All @@ -846,7 +866,7 @@
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.RxSwiftCommunity.RxSwiftUtilitiesTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.0;
};
name = Release;
};
Expand All @@ -869,7 +889,7 @@
PRODUCT_NAME = RxSwiftUtilities;
SDKROOT = appletvos;
SKIP_INSTALL = YES;
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.0;
TARGETED_DEVICE_FAMILY = 3;
TVOS_DEPLOYMENT_TARGET = 9.0;
};
Expand All @@ -894,7 +914,7 @@
PRODUCT_NAME = RxSwiftUtilities;
SDKROOT = appletvos;
SKIP_INSTALL = YES;
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.0;
TARGETED_DEVICE_FAMILY = 3;
TVOS_DEPLOYMENT_TARGET = 9.0;
};
Expand All @@ -913,7 +933,7 @@
PRODUCT_BUNDLE_IDENTIFIER = "com.RxSwiftCommunity.RxSwiftUtilities-tvOSTests";
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = appletvos;
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.0;
TVOS_DEPLOYMENT_TARGET = 10.0;
};
name = Debug;
Expand All @@ -931,7 +951,7 @@
PRODUCT_BUNDLE_IDENTIFIER = "com.RxSwiftCommunity.RxSwiftUtilities-tvOSTests";
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = appletvos;
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.0;
TVOS_DEPLOYMENT_TARGET = 10.0;
};
name = Release;
Expand All @@ -957,7 +977,7 @@
PRODUCT_NAME = RxSwiftUtilities;
SDKROOT = macosx;
SKIP_INSTALL = YES;
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.0;
};
name = Debug;
};
Expand All @@ -982,7 +1002,7 @@
PRODUCT_NAME = RxSwiftUtilities;
SDKROOT = macosx;
SKIP_INSTALL = YES;
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.0;
};
name = Release;
};
Expand All @@ -1002,7 +1022,7 @@
PRODUCT_BUNDLE_IDENTIFIER = "com.RxSwiftCommunity.RxSwiftUtilities-macOSTests";
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = macosx;
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.0;
};
name = Debug;
};
Expand All @@ -1022,7 +1042,7 @@
PRODUCT_BUNDLE_IDENTIFIER = "com.RxSwiftCommunity.RxSwiftUtilities-macOSTests";
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = macosx;
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.0;
};
name = Release;
};
Expand All @@ -1046,7 +1066,7 @@
PRODUCT_NAME = RxSwiftUtilities;
SDKROOT = watchos;
SKIP_INSTALL = YES;
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.0;
TARGETED_DEVICE_FAMILY = 4;
WATCHOS_DEPLOYMENT_TARGET = 2.0;
};
Expand All @@ -1072,7 +1092,7 @@
PRODUCT_NAME = RxSwiftUtilities;
SDKROOT = watchos;
SKIP_INSTALL = YES;
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.0;
TARGETED_DEVICE_FAMILY = 4;
WATCHOS_DEPLOYMENT_TARGET = 2.0;
};
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "0800"
LastUpgradeVersion = "0920"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand All @@ -26,6 +26,7 @@
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
language = ""
shouldUseLaunchSchemeArgsEnv = "YES"
codeCoverageEnabled = "YES">
<Testables>
Expand Down Expand Up @@ -56,6 +57,7 @@
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
language = ""
launchStyle = "0"
useCustomWorkingDirectory = "NO"
ignoresPersistentStateOnLaunch = "NO"
Expand Down
Loading

0 comments on commit 21d24a4

Please sign in to comment.