Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yet another Carthage support #37

Merged
merged 15 commits into from
Apr 11, 2020

Conversation

mickamy
Copy link
Member

@mickamy mickamy commented Feb 1, 2020

There are some PRs trying to add Carthage support (#7 or #28).
But all of them are stale and I can no see any progress for a long time.

So I created a yet another Carthage support PR.

@mickamy
Copy link
Member Author

mickamy commented Mar 9, 2020

@fassko Is it possible to review/merge this one?

@fassko
Copy link
Member

fassko commented Mar 9, 2020

@mickamy thanks for your contribution. I haven't used Carthage myself. Can you tell how to test this?

@mickamy
Copy link
Member Author

mickamy commented Apr 11, 2020

Actually this PR does not work well for now.
Because of the absence of the .xcodeproj file in this repo.

AFAIK, Carthage searches xcodeproj or xcworkspace file in repo on running carthage update or some other command to install, to detect Shared scheme contained in it so that Carthage can build it.

There is an issue discussing about supporting SwiftPM managed project in Carthage though, it seems have no progress lately.
ref: Carthage/Carthage#1226

I guess we need to manage xcodeproj file again to support Carthage for now.
Any thoughts on this?

@fassko

@mickamy
Copy link
Member Author

mickamy commented Apr 11, 2020

Updated PR and included .xcodeproj file to repo.
And I also created a repo that proves my implementation works fine.
https://github.com/mickamy/RxAnimatedCarthageExample

@fassko Is it enough for testing?
I can update example or whatsoever quickly, because I stay home for the COVID-19 situation.

@fassko fassko merged commit bc08a33 into RxSwiftCommunity:master Apr 11, 2020
@rxswiftcommunity
Copy link

Thanks a lot for contributing @mickamy! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@fassko
Copy link
Member

fassko commented Apr 11, 2020

Thanks @mickamy

@mickamy mickamy deleted the feature/carthage-support branch April 12, 2020 00:07
@mickamy mickamy mentioned this pull request Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants