Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code smells #94

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix code smells #94

wants to merge 9 commits into from

Conversation

pondermatic
Copy link

Fix issues that are considered code smells:

  • method calls with mismatched number of parameters
  • inconsistent return points in methods with missing return statements (explicity return null)

@pondermatic
Change implicit return of null to explicit.
3694e7a
@pondermatic
Fix method calls with mismatched number of parameters.
55be839
@pondermatic
Fix JWS->setPayload() calls with mismatched number of parameters.
4db0107
@pondermatic
Change PHPUnit_Framework_TestCase to PHPUnit\Framework\TestCase.
889dada 
This allows the tests to be run with PHPUnit 4.8.*, 5.4.* and 6.*.
@pondermatic
Change PHPUnit version.
a916e3d 
'@stable' causes testing of PHP 7.0 to use PHPUnit 6.4, which breaks compatibility with PHPUnit 4.8 and 5.7.
@pondermatic
Update "too few arguments" tests for PHP 7.1.
f203ab3
@pondermatic
Fix HHVM array to string issue.
ddd2f0a 
If the HTTP header context option is an array of headers, HHVM sends an 'Array to string conversion' notice.
@pondermatic
Merge branch 'PHPUnit' into code_smell
83327a3
@pondermatic pondermatic mentioned this pull request Nov 13, 2017
Open
@pondermatic
Revert "Merge branch 'PHPUnit' into code_smell"
cc09e74 
This reverts commit 83327a3, reversing
changes made to 4db0107.
@pondermatic
Copy link
Author

pondermatic commented Nov 19, 2017 •
edited
Loading

#96 should be merged first in order to pass PHP 7 and HHVM tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pondermatic