[WIP] European central bank exchange rate #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add data/ecb_example_response.xml use roxmltree
sfraczek
force-pushed
the
european_central_bank
branch
from
2778af6 to
c9d8615
Compare
Closed
jczaja
reviewed
Dec 31, 2024
| use chrono; | ||
| use roxmltree; | ||
|
|
||
| pub fn get_eur_to_usd_exchange_rate( |
There was a problem hiding this comment.
why this is named "get_eur_to_usd_exchange_rate" ? The exchange rate we need is USD to EUR ?
There was a problem hiding this comment.
My understanding is that we need EUR to USD because I assume that the denominator is 1 not nominator. In case of EUR/USD (which I read as euro to usd) if denominator is 1 than USD = 1 and EUR < 1 and overall value is < 1.
in this function I download the opposite USD/EUR and invert it because I haven't seen the inverse anywhere on ECB api.
There was a problem hiding this comment.
I can change it if you prefer, I'm not fluent in financial market terminology so I don't know which is right, I was doing it so it is easy for me to understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds european central bank exchange rate.