replace filechooser with native file chooser #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces FileChooser with FileDialog which is system specific.
Fixes issue #95
It is pretty and it works.
bugs:
Entering empty string in double quotes
""opens a message box warning with hilarious text "Catastrophic failure". After the message box is closed, the dialog still operates as usual. I don't think there is any way to fix it other than report it to fltk-rs.The files entered are not validated if they exists at this stage, because the files may be deleted afterward before clicking
execute. However I think that additional layer of validation wouldn't hurt becuase one can enter unusual filenames. Especially the top one:Fortunately, the execution validates the filenames which gives
Error opening and parsing file: ...2022\"202208.pdf" "0" "?"Todo: