Initial commit for KBKDF #87
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
commented
Oct 29, 2023
| const FEEDBACK_KI: bool = false; | ||
| } | ||
|
|
||
| pub struct Counter<Prf, K, R = U32> { |
There was a problem hiding this comment.
not so fan of the default values for R. I wonder if maybe a type alias might not be better. (ala x509-cert::Certificate)
baloo
commented
Oct 29, 2023
|
|
||
| // Fixed input data | ||
| h.update(label); | ||
| if use_separator { |
There was a problem hiding this comment.
This behavior is not standard, but TPM specification relies on KBKDF and calls for separator to be optional (https://trustedcomputinggroup.org/wp-content/uploads/TCG_TPM2_r1p59_Part1_Architecture_pub.pdf#page=73).
Added only if Label is not present or if the last octet of Label is not zero.
For a time I intended to provide that behavior as a type parameter, but I'm not sure now. I'd love opinion.
baloo
force-pushed
the
baloo/kbkdf/init
branch
from
9002671
to
013eec6
Compare
|
Nist has test vectors http://csrc.nist.gov/groups/STM/cavp/index.html |
baloo
commented
Oct 30, 2023
kbkdf/src/lib.rs
Outdated
| /// Derives `key` from `kin` and other parameters. | ||
| fn derive( | ||
| &self, | ||
| kin: &GenericArray<u8, Prf::KeySize>, |
There was a problem hiding this comment.
This is incorrect and doesn't work with hmac.
I think I'll need for it to pass in the Prf and reset it.
baloo
force-pushed
the
baloo/kbkdf/init
branch
from
847ceb0
to
9df77b4
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements KBKDF as defined in https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-108r1.pdf
This also implements non-standards behavior like
use-landuse-separator. Those are used in TPMs for the KDFa method for example. See comments below for questions about that.Missing: