Introduce a public constant for Rodio's default sample rate #646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help to reduce number of sample rate conversions. Setting it to current de-facto default (44.1kHz).
There is still a question whether we should use
cpal::SampleRate
or plain integer. With either choice it is better to use the same type everywhere in the API. Currently some functions acceptcpal::SampleRate
while others useu32
.cpal::SampleRate
helps with type-checks but does not really provide useful services.Also partially relieves #208. The rate converter has to be fixed still but with default sample rate less resampling is needed.