Make DynamicMixer and OutputStream generic
#547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new trait, `Mixer`, and refactors some of the code around generic mixers in order to support it. This is to make more of the code reusable without rewriting - specifically, to support a feature that I would like to implement in `bevy_audio` where audio sources can send audio to an intermediate mixer. The motivation for this was to add a global limiter to all game audio, so that loud sounds did not cause clipping on the master bus, but another possible usecase would be to split in-game audio and menu audio into separate "worlds" and apply, for example, a low-pass filter while in the pause screen.
|
It looks like the test failures are due to unrelated code, and are because of the addition of redundant import checks to |
eira-fransham
added a commit
to eira-fransham/bevy
that referenced
this pull request
Mar 5, 2024
This commit adds a new component, `AudioTarget`. This component allows marking sources to be played via a specific `OutputStreamHandle` instead of the global one. At time of writing, changing the audio target will result in restarting the source, as `rodio` provides no way to get the inner source queue for a `Sink`. This is already the case for the current version of Bevy when a component's `AudioSink` is removed, however, so I think that this behavior is acceptable for now. This allows users to specifically target certain audio devices, and when [rodio#547](RustAudio/rodio#547) lands it will allow users to use intermediate mixers - e.g. to add global or per-item-set effects such as reverb.
|
A more-minimal version of this PR would just make |
hamirmahal
reviewed
Mar 18, 2024
There was a problem hiding this comment.
It looks like the test failures are due to unrelated code, and are because of the addition of redundant import checks to
unused_imports.
The test failures should be gone on the main branch now because of #554.
|
Could you rebase this on main? (or merge main into it). Then you'll get the fixed (thanks @hamirmahal) test suite. |
|
You're welcome, @dvdsk! |
dvdsk
added
the
waiting for rebase
dvdsk
force-pushed
the
master
branch
3 times, most recently
from
b10961c
to
a7f67b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new trait,
Mixer, and refactors some of the code around generic mixers in order to support it. This is to make more of the code reusable without rewriting - specifically, to support a feature that I would like to implement inbevy_audiowhere audio sources can send audio to an intermediate mixer. The motivation for this was to add a global limiter to all game audio, so that loud sounds did not cause clipping on the master bus, but another possible usecase would be to split in-game audio and menu audio into separate "worlds" and apply, for example, a low-pass filter while in the pause screen.