Required features for Rust For Linux #3309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MajoraSans
force-pushed
the
required_features
branch
from
37984d9 to
23df30c
Compare
* ast/rust-ast-visitor.cc (DefaultASTVisitor::visit): enabled a default visitor to be overrided * ast/rust-ast-visitor.h: passes a method virtual * checks/errors/rust-feature-gate.cc (FeatureGate::visit): implements all checks for the new features * checks/errors/rust-feature-gate.h: the prototypes of the new checkers * checks/errors/rust-feature.cc (Feature::create): implements the recognition and creation of some new features * checks/errors/rust-feature.h: creation of the features name in the enum gcc/testsuite/ChangeLog: * rust/compile/feature_extern_types.rs: Move to... * rust/compile/features/extern_types.rs: ...here. * rust/compile/feature_intrinsics.rs: Move to... * rust/compile/features/intrinsics.rs: ...here. * rust/compile/features/arbitrary_self_types_activated.rs: New test. * rust/compile/features/arbitrary_self_types_not_activated.rs: New test. * rust/compile/features/associated_type_defaults_activated.rs: New test. * rust/compile/features/const_trait_impl_activated.rs: New test. * rust/compile/features/doc_cfg_activated.rs: New test. * rust/compile/features/doc_cfg_not_activated.rs: New test. * rust/compile/features/feature.exp: New test. * rust/compile/features/impl_trait_in_assoc_type_activated.rs: New test. * rust/compile/features/impl_trait_in_assoc_type_not_activated.rs: New test. * rust/compile/features/register_tool_activated.rs: New test. * rust/compile/features/register_tool_not_activated.rs: New test.
MajoraSans
force-pushed
the
required_features
branch
from
23df30c to
be4b230
Compare
|
As for now, all features marked as "Required" in #3210 are recognized, except |
* checks/errors/rust-feature-gate.cc (FeatureGate::visit): cleaning file. * checks/errors/rust-feature-gate.h: cleaning file. * checks/errors/rust-feature.cc: cleaning file. gcc/testsuite/ChangeLog: * rust/compile/features/associated_type_defaults_activated.rs: Changed test to code that used the tested feature. * rust/compile/features/associated_type_defaults_not_activated.rs: New test. Will be failing, but dg-error not set up yet. Signed-off-by: lucas.plantrose <[email protected]>
MajoraSans
force-pushed
the
required_features
branch
from
be4b230 to
a9e2683
Compare
philberty
reviewed
Dec 18, 2024
| #include "rust-path.h" | ||
| #include "rust-type.h" | ||
| #include "rust-tyty.h" | ||
| #include <iostream> |
There was a problem hiding this comment.
this should use rust-system.h i dont see why you need iostream and rust-tyty.h for the type abstractions
There was a problem hiding this comment.
I do not need them actually, my lsp just went overboard with the includes ^^'
philberty
reviewed
Dec 18, 2024
| @@ -435,7 +435,7 @@ class DefaultASTVisitor : public ASTVisitor | |||
| virtual void visit (AST::StructPatternElements &spe); | |||
| virtual void visit (AST::MaybeNamedParam ¶m); | |||
|
|
|||
| void visit (AST::Attribute &attribute) {} | |||
| virtual void visit (AST::Attribute &attribute) {} | |||
There was a problem hiding this comment.
does this need virtual i dont see where your overriding it
There was a problem hiding this comment.
oh wait scratch that i see now sorry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3233.
This PR is here to show the work done on the recognition of the required features for Rust for Linux mentioned in the #3210, and aims to implement all of them.