Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gccrs: Fix recursive type query on impl block types #3245

Closed
wants to merge 2 commits into from

Conversation

philberty
Copy link
Member

@philberty philberty commented Nov 6, 2024

Fixes #2905

gcc/rust/ChangeLog:

	* typecheck/rust-type-util.cc (query_type): bad debug log message

Signed-off-by: Philip Herron <[email protected]>
@philberty philberty added this to the Remaining typecheck issues milestone Nov 6, 2024
@philberty philberty requested review from CohenArthur and removed request for CohenArthur November 6, 2024 17:46
@philberty philberty changed the title gccrs: fix marker trait checks like sized on generic types gccrs: fix marker trait checks like sized on generic types WIP Nov 6, 2024
Fixes #2905

gcc/rust/ChangeLog:

	* typecheck/rust-type-util.cc (query_type): check for recursive type query

gcc/testsuite/ChangeLog:

	* rust/compile/nr2/exclude: nr2 cant handle this
	* rust/compile/issue-2905-1.rs: New test.
	* rust/compile/issue-2905-2.rs: New test.

Signed-off-by: Philip Herron <[email protected]>
@philberty philberty force-pushed the phil/inference-bug-fix branch from 998b3b7 to 1e65e7a Compare November 6, 2024 20:12
@philberty philberty changed the title gccrs: fix marker trait checks like sized on generic types WIP gccrs: Fix recursive type query on impl block types Nov 6, 2024
@philberty philberty requested a review from CohenArthur November 6, 2024 20:13
@philberty philberty closed this Nov 6, 2024
@philberty philberty deleted the phil/inference-bug-fix branch December 12, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Weird root segment type resolution issue depending on order of items?
1 participant