Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of types in DefaultResolver #3181

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

powerboat9
Copy link
Contributor

No description provided.

Copy link
Member

@P-E-P P-E-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong but this file looks like it could be cut in half by removing all those empty definitions.

gcc/rust/resolve/rust-default-resolver.cc Outdated Show resolved Hide resolved
gcc/rust/ChangeLog:

	* resolve/rust-default-resolver.cc
	(DefaultResolver::visit): Remove some empty overloads which
	DefaultASTVisitor::visit should be able to handle.
	* resolve/rust-default-resolver.h
	(DefaultResolver::visit): Likewise.

gcc/testsuite/ChangeLog:

	* rust/compile/nr2/exclude: Remove entries.

Signed-off-by: Owen Avery <[email protected]>
Copy link
Member

@P-E-P P-E-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you!

@P-E-P P-E-P added this pull request to the merge queue Sep 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2024
@powerboat9
Copy link
Contributor Author

Looks like this failed due to CI issues, can you try submitting it again?

@P-E-P P-E-P added this pull request to the merge queue Sep 26, 2024
Merged via the queue into Rust-GCC:master with commit 71affd2 Sep 26, 2024
12 checks passed
@powerboat9 powerboat9 deleted the improve-type-visit branch September 26, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants