-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build dependencies for Fedora #3154
Conversation
You need to fix you git commit message GCC is super strict on this can you see the error message in the commit checker? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git commit message needs fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! this looks good :) as @philberty pointed out, you need to fix the commit message to adhere to a certain format.
from the root of the gccrs project, you can use the following command and script to do it simply:
git show -1 | ./contrib/mklog.py
ChangeLog: * README.md: Add fedora deps. Signed-off-by: Jarkko Sakkinen <[email protected]>
I did the small changelog fix so we can merge this. |
Oops, so what happened is that I changed my day job on October. So thus have had lots of reorg going on in my life! I thank you for merging, and sincerely apologize not fixing it myself! |
no worries! thanks for originally submitting the patch :) |
Thank you for making Rust GCC better!
If your PR fixes an issue, you can add "Fixes #issue_number" into this
PR description and the git commit message. This way the issue will be
automatically closed when your PR is merged. If your change addresses
an issue but does not fully fix it please mark it as "Addresses #issue_number"
in the git commit message.
Here is a checklist to help you with your PR.
make check-rust
passes locallyclang-format
gcc/testsuite/rust/
Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
*Please write a comment explaining your change. This is the message
that will be part of the merge commit.