Add improved error when a field is redefined in a struct constructor #2797
Conversation
robertgoss
force-pushed
the
gossr/error_code_e0062_i2381
branch
6 times, most recently
from
5013ae3 to
d089463
Compare
Fixes Rust-GCC#2381 If a struct type is initialized with one of it's fields repeated it will currently issue an error at the use site. However we would like to give the rust error code and (like rustc) show both the specifications for the field to help the user diagnose the issue. We move the check after the index for the field has been established so we can look up if the field has already been defined and get it's location. We update the visit method to return if it has handled an error otherwise we then output a second fatal error as not all the field in the specification have been processed. gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-struct-field.h: Allow visit to return a bool * typecheck/rust-hir-type-check-struct.cc: Improve check of repeat fields gcc/testsuite/ChangeLog: * rust/compile/repeated_constructor_fields.rs: Added case with constructor field repeated Signed-off-by: Robert Goss <[email protected]>
robertgoss
force-pushed
the
gossr/error_code_e0062_i2381
branch
from
d089463 to
0bf6ce3
Compare
|
👋 I believe this is your first contribution to GCC / GCCrs. Have you read https://gcc.gnu.org/dco.html? If so, can you state that in your (first) PR description, so that it's written somewhere? Thanks! Also, small typo in the commit log where you are missing a space in |
Thank you I have added a comment saying this in the PR description now.
Ah yes - should be fixed now thanks. |
There was a problem hiding this comment.
Nice work this seems very reasonable. I was slightly concerned about the changing of the visit signiture to return bool but i think this works here because i dont think its a proper visitor here in that class iirc.
Thanks! More eyes on the type checker please!
Fixes #2381
If a struct type is initialized with one of it's fields repeated it will currently issue an error at the use site. However we would like to give the rust error code and (like rustc) show both the specifications for the field to help the user diagnose the issue.
We move the check after the index for the field has been established so we can look up if the field has already been defined and get it's location.
We update the visit method to return if it has handled an error otherwise we then output a second fatal error as not all the field in the specification have been processed.
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog:
I have read and accept the developers certificate of origin at https://gcc.gnu.org/dco.html