expand: C++ify proc macro decls generation #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a stringstream instead of the older, better and more readable `sprintf` version as the format overflow warning in current GCC is overzealous and triggered on that code, despite the non-zero allocation. Even using an unsigned value instead of a signed one for the `size` variable caused issues, so switching to this is simpler. gcc/rust/ChangeLog: * expand/rust-proc-macro.cc: Use stringstream instead of sprintf. * rust-system.h: Include <iomanip>.
|
the code was too simple and readable anyway, this is much better, makes me feel like we're doing actual C++ /s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a stringstream instead of the older, better and more readable
sprintfversion as the format overflow warning in current GCC isoverzealous and triggered on that code, despite the non-zero allocation.
Even using an unsigned value instead of a signed one for the
sizevariable caused issues, so switching to this is simpler.
gcc/rust/ChangeLog: