Handle async qualifier inside trait
#2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braw-lee
force-pushed
the
unhandledAsync
branch
2 times, most recently
from
0187d64 to
72c7e45
Compare
|
second commit fixes #2767 |
|
@philberty review pls |
CohenArthur
reviewed
Dec 26, 2023
| @@ -5784,6 +5785,7 @@ Parser<ManagedTokenSource>::parse_trait_impl_item () | |||
| // function or method | |||
| return parse_trait_impl_function_or_method (visibility, | |||
| std::move (outer_attrs)); | |||
| case ASYNC: | |||
There was a problem hiding this comment.
const is handled this way because inside a trait, you could have a const variable or a constant function:
impl Foo for u32 {
const TRAIT_ASSOC_CST: u32 = 15;
const fn constant_fn() -> u32 { 14 }
}for async, we can only have async functions - so we don't need to bundle the cases for CONST and ASYNC together.
Instead, this is what I would like to see:
Suggested change
| case ASYNC: | |
| case ASYNC: | |
| return parse_async_item (visibility, std::move(outer_attrs)) | |
| case CONST: | |
| /* snip */ |
Comment on lines
+110
to
+113
| // may change soon | ||
| if (qualifiers.is_async () && context.back () == Context::TRAIT_IMPL) | ||
| rust_error_at (function.get_locus (), ErrorCode::E0706, | ||
| "functions in traits cannot be declared %<async%>"); |
braw-lee
force-pushed
the
unhandledAsync
branch
2 times, most recently
from
4c00228 to
a8dd9ff
Compare
Fixes Rust-GCC#2778 gcc/rust/ChangeLog: * parse/rust-parse-impl.h (Parser::parse_trait_impl_item): Handled `async` items Signed-off-by: Kushal Pal <[email protected]>
braw-lee
force-pushed
the
unhandledAsync
branch
from
a8dd9ff to
f5f0f3a
Compare
Fixes Rust-GCC#2767 gcc/rust/ChangeLog: * checks/errors/rust-ast-validation.cc (ASTValidation::visit): Added check for `async` function inside trait. gcc/testsuite/ChangeLog: * rust/compile/issue-2767.rs: New test. Signed-off-by: Kushal Pal <[email protected]>
braw-lee
force-pushed
the
unhandledAsync
branch
from
f5f0f3a to
e97a817
Compare
|
fixed suggested changes, thanks for review @CohenArthur |
CohenArthur
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
LGTM! If you'd like @braw-lee you could implement the same sort of pattern for trait functions and parsing of async functions for regular impls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2778
gcc/rust/ChangeLog:
Thank you for making Rust GCC better!
If your PR fixes an issue, you can add "Fixes #issue_number" into this
PR description and the git commit message. This way the issue will be
automatically closed when your PR is merged. If your change addresses
an issue but does not fully fix it please mark it as "Addresses #issue_number"
in the git commit message.
Here is a checklist to help you with your PR.
make check-rustpasses locallyclang-formatgcc/testsuite/rust/Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
*Please write a comment explaining your change. This is the message
that will be part of the merge commit.