Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change cfg stripper to use default visitor #2758

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Change cfg stripper to use default visitor #2758

merged 1 commit into from
Dec 14, 2023

Conversation

P-E-P
Copy link
Member

@P-E-P P-E-P commented Nov 23, 2023 •
edited
Loading

Make cfg stripper inherit from the default visitor.

@P-E-P P-E-P added this to the GCC 14.1 release milestone Nov 23, 2023
@P-E-P P-E-P self-assigned this Nov 23, 2023
@P-E-P P-E-P changed the title WIP Change cfg stripper to use default visitor Change cfg stripper to use default visitor Nov 24, 2023
@P-E-P P-E-P force-pushed the cfg-strip-with-default-visitor branch 2 times, most recently from 62cbd9c to 5cfd1b5 Compare November 24, 2023 13:48
@P-E-P P-E-P added cleanup and removed enhancement labels Nov 27, 2023
@P-E-P P-E-P force-pushed the cfg-strip-with-default-visitor branch 3 times, most recently from b402748 to a828051 Compare December 12, 2023 12:02
@P-E-P
Change cfg stripper to use default visitor
1debbc0 
Cfg visitor used it's own visit patterns, this made the code longer than
required.

gcc/rust/ChangeLog:

	* expand/rust-cfg-strip.cc (CfgStrip::visit): Change calls from visitor
	to default visitor.
	(CfgStrip::go): Add call to visit crate.
	* expand/rust-cfg-strip.h (class CfgStrip): Update prototypes and
	remove empty ones.
	* ast/rust-ast-visitor.cc: add WhereClause condition check.

Signed-off-by: Pierre-Emmanuel Patry <[email protected]>
@P-E-P P-E-P force-pushed the cfg-strip-with-default-visitor branch from a828051 to 1debbc0 Compare December 12, 2023 12:18
@P-E-P P-E-P marked this pull request as ready for review December 12, 2023 13:14
@P-E-P P-E-P added this pull request to the merge queue Dec 14, 2023
Merged via the queue into Rust-GCC:master with commit 6c80746 Dec 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CohenArthur CohenArthur CohenArthur approved these changes

Assignees

@P-E-P P-E-P

Labels
cleanup
Projects
Project Pineapple
Status: Done
Milestone
GCC 14.1 release
Development

Successfully merging this pull request may close these issues.
2 participants
@P-E-P @CohenArthur