Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make resolution of AssociatedItem instances polymorphic #2683

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Make resolution of AssociatedItem instances polymorphic #2683

merged 1 commit into from
Oct 20, 2023

Conversation

powerboat9
Copy link
Contributor

Depends on #2679

@powerboat9 powerboat9 force-pushed the assoc-resolve branch 2 times, most recently from d236d01 to 0cb6c3c Compare October 15, 2023 04:22
@powerboat9
Make resolution of AssociatedItem instances polymorphic
634007b 
gcc/rust/ChangeLog:

	* resolve/rust-ast-resolve-implitem.h
	(ResolveToplevelImplItem::go): Take AssociatedItem as parameter.
	(ResolveTopLevelTraitItems::go): Likewise.
	* resolve/rust-ast-resolve-item.cc
	(ResolveTraitItems::go): Likewise.
	(ResolveItem::resolve_impl_item): Likewise.
	(ResolveImplItems::go): Likewise.
	* resolve/rust-ast-resolve-item.h
	(ResolveTraitItems::go): Likewise.
	(ResolveItem::resolve_impl_item): Likewise.
	(ResolveImplItems::go): Likewise.

Signed-off-by: Owen Avery <[email protected]>
CohenArthur
CohenArthur approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great too. I love PRs that remove more code than they add :D

@CohenArthur CohenArthur added this pull request to the merge queue Oct 20, 2023
Merged via the queue into Rust-GCC:master with commit 4931eb8 Oct 20, 2023
9 checks passed
@powerboat9 powerboat9 deleted the assoc-resolve branch October 20, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CohenArthur CohenArthur CohenArthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@powerboat9 @CohenArthur