Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unecessary "empty vector" comments #2640

Closed
wants to merge 0 commits into from

Conversation

ZanF21
Copy link
Contributor

@ZanF21 ZanF21 commented Oct 2, 2023

Addresses #2358

  • Not sure if checks should be added in place of the comments


Removed unnecessary comments

@CohenArthur CohenArthur self-assigned this Oct 2, 2023
@CohenArthur CohenArthur self-requested a review October 2, 2023 11:24
@dkm
Copy link
Member

dkm commented Oct 2, 2023

You don't need to add more test, as the change are unlikely to break any code checks.
BUT, you still need to come with a correct git commit log message.
You can check for other commit doing similar changes to comments (look for typo check as a good example).

You can see above that everything is fine, except for the commit message that lacks a GNU ChangeLog.

You also need to state that you have read and understood the https://gcc.gnu.org/dco.html in the description of this Pull Request, and add a Signed-off-by line to your commit message. Given the nature of your change, it's not mandatory, but it will make our life easier to have it.

Thanks!

@powerboat9
Copy link
Contributor

Try taking a look at, and running all/part of, gcc-git-customization.sh. There's an alias called gcc-commit-mklog that should automate part of changelog generation. You should probably also read https://www.gnu.org/prep/standards/standards.html#Change-Logs and https://gcc.gnu.org/codingconventions.html#ChangeLogs.

@CohenArthur CohenArthur changed the title Addresses #2358 Remove unecessary "empty vector" comments Oct 2, 2023
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! the changes look good, but I agree with what Marc has said - the formatting of commits is important as we send our commits to GCC afterwards without modification. if you need help getting your commit formatted properly let me know on Zulip!

@ZanF21
Copy link
Contributor Author

ZanF21 commented Oct 3, 2023

I'll get working on that asap

P.S. i will need help

@ZanF21
Copy link
Contributor Author

ZanF21 commented Oct 4, 2023

mb .. took longer than expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants