Skip to content

Commit

Permalink
Fix nightly rustc warnings
Browse files Browse the repository at this point in the history
libgrust/ChangeLog:

	* libformat_parser/Cargo.toml:
	Used crate-type instead of depricated crate_type.
	* libformat_parser/generic_format_parser/src/lib.rs:
	Remove dead code.
	* libformat_parser/src/lib.rs: Likewise.

Signed-off-by: Kushal Pal <[email protected]>
  • Loading branch information
braw-lee authored and CohenArthur committed Jul 16, 2024
1 parent 48c94c4 commit ff59d15
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 31 deletions.
2 changes: 1 addition & 1 deletion libgrust/libformat_parser/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ libc = "0.2"
generic_format_parser = { path = "generic_format_parser" }

[lib]
crate_type = ["staticlib", "rlib"]
crate-type = ["staticlib", "rlib"]

[[bin]]
name = "format_parser_test"
Expand Down
16 changes: 0 additions & 16 deletions libgrust/libformat_parser/generic_format_parser/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,6 @@ fn is_id_continue(c: char) -> bool {
unicode_xid::UnicodeXID::is_xid_continue(c)
}

// Workaround for Ubuntu 18.04. The default Rust package is 1.65 (and unlikely to change I assume?), but the
// generic format parser library uses `is_some_and` which was introduced in 1.70. So this is a reimplementation,
// directly taken from the standard library sources
trait IsSomeAnd<T> {
fn is_some_and(self, f: impl FnOnce(T) -> bool) -> bool;
}

impl<T> IsSomeAnd<T> for Option<T> {
fn is_some_and(self, f: impl FnOnce(T) -> bool) -> bool {
match self {
None => false,
Some(x) => f(x),
}
}
}

// use rustc_lexer::unescape;
pub use Alignment::*;
pub use Count::*;
Expand Down
14 changes: 0 additions & 14 deletions libgrust/libformat_parser/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,6 @@

use std::ffi::CStr;

trait StringLeakExt {
fn leak<'a>(self) -> &'a mut str;
}

impl StringLeakExt for String {
fn leak<'a>(self) -> &'a mut str {
Box::leak(self.into_boxed_str())
}
}

trait IntoFFI<T> {
fn into_ffi(self) -> T;
}
Expand Down Expand Up @@ -98,10 +88,6 @@ mod ffi {
// InlineAsm,
// }

#[derive(Copy, Clone)]
#[repr(C)]
struct InnerOffset(usize);

/// A piece is a portion of the format string which represents the next part
/// to emit. These are emitted as a stream by the `Parser` class.
#[derive(Debug, Clone, PartialEq)]
Expand Down

0 comments on commit ff59d15

Please sign in to comment.