Remove stray enum instance #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This `enum LOG_LEVELS` declaration also included a _variable name_, causing RuntimeTools/appmetrics#641. It ended up defining a `Log_levels` variable in every compilation unit that included "Log.h", which then caused duplicate symbols at link time. I don't know if there was a reason for this definition, but it looks like a bug to me … if not, maybe it can be fixed by just putting a `static` in front? idk. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
enum LOG_LEVELSdeclaration also included a variable name,causing RuntimeTools/appmetrics#641. It ended
up defining a
Log_levelsvariable in every compilation unit thatincluded "Log.h", which then caused duplicate symbols at link time.
I don't know if there was a reason for this definition, but it looks
like a bug to me … if not, maybe it can be fixed by just putting a
staticin front? idk.Thanks!