WIP: Support appmetrics v4 and Elasticsearch/Kibana 6 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking changes: * Removed support for older Node.js versions * This package now has the renamed connector() function as its main export with a new signature * The connector no longer depends on any particular version of appmetrics * Removed logic for automatically configuring Kibana's default index
Breaking changes: * Rename "applicationName" field to "app" * Rename "hostName" field to "host" * Rename "timestamp" field to "@timestamp" * Refactor appmetrics mappings to all be of a single type (fixes RuntimeTools#30) * Preconfigured Kibana visualizations are only compatible on Kibana 4 (untested on 5.x)
|
wow, big change :-) . Let me take a look at what you are proposing |
kherock
changed the title
|
No rush, I should also clarify that this is definitely WIP. Working with Logstash is new to me so I'll have to double check that my changes all integrate properly when I have a chance. |
|
any updates on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find
appmetricsreally useful but the code here is kind of a mess and doesn't work with current versions of Node.js, Kibana, or Elasticsearch. I'll open a PR here in hopes this gets some attention, but in the meantime I'll be trying to maintain my fork that anybody stumbling across here can install withI've also included the changes from #22. Be warned most of this is largely untested aside from the few metrics I'm currently taking advantage of in combination with Elasticsearch 6.
Breaking changes:
"applicationName"field to"app""hostName"field to"host""timestamp"field to"@timestamp"