Remove legacy Ruby version conditionals #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
force-pushed
the
chore/remove-legacy-checks
branch
2 times, most recently
from
e21dc88
to
6a827f5
Compare
tagliala
changed the title
tagliala
changed the title
tagliala
force-pushed
the
chore/remove-legacy-checks
branch
3 times, most recently
from
0aa4bfe
to
cb51adb
Compare
Also: - Test against JRuby 9.4 - Remove conditional installation of `json` on JRuby, because it appears to be part of the standard library on all supported Ruby versions - Move `rbs` and `typeprof` to Gemfile and conditionally install them only on supported Ruby platforms Note: the minimum JRuby version which passes the specs is 9.4.2.0
tagliala
force-pushed
the
chore/remove-legacy-checks
branch
from
cb51adb
to
62652c8
Compare
semmons99
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
jsonon JRuby, because it appearsto be part of the standard library on all supported Ruby versions
rbsandtypeprofto Gemfile and conditionally install themonly on supported Ruby platforms
Note: the minimum JRuby version which passes the specs is 9.4.2.0