added SIGTERM signal handler for main loop #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that using the shell approach in a systemd service, as discussed in this issue, results in Python subprocesses not shutting down when running systemctl restart or systemctl stop (e.g., during fan curve updates). To address this, I have implemented a signal handler to ensure a graceful shutdown (and restoration of defaults) when a SIGTERM signal is received.
To make this fix effective, the ExecStart in the service configuration also needs to be updated:
ExecStart=/bin/bash -c 'cd /path/to/nvidia_fan_control_linux && source fan/bin/activate && python nvidia_fan_control.py'