Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSVC error on unknown identifier uint in function.hpp #301

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

haiiliin
Copy link
Contributor

I found this error when trying to build binder with MSVC. Relates to #20, #59.

@haiiliin
Copy link
Contributor Author

haiiliin commented Jun 17, 2024

By the way, I set up a Python package for binder and published the pre-built wheels to PyPI, if you are willing to merge it to this project, I'd be willing to help.

Copy link
Member

@lyskov lyskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, - thank you @haiiliin !

@lyskov lyskov merged commit 7d6ec91 into RosettaCommons:master Jun 19, 2024
16 of 17 checks passed
@haiiliin haiiliin deleted the fix-unknown-uint branch June 20, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants