update filename regex to match .generated.sql files (#109)

pkg/spanner/migration.go

@@ -40,7 +40,8 @@ var (
  // 001.sql
  // 001_name.sql
  // 001_name.up.sql
- migrationFileRegex = regexp.MustCompile(`^([0-9]+)(?:_([a-zA-Z0-9_\-]+))?(\.up)?\.sql$`)
+ // 001_name.generated.sql
+ migrationFileRegex = regexp.MustCompile(`^([0-9]+)(?:_([a-zA-Z0-9_\-]+))?(?:[.]up|[.]generated)?\.sql$`)
 
  MigrationNameRegex = regexp.MustCompile(`[a-zA-Z0-9_\-]+`)
 
@@ -114,7 +115,7 @@ func LoadMigrations(dir string, toSkipSlice []uint, detectPartitionedDML bool) (
  }
 
  matches := migrationFileRegex.FindStringSubmatch(f.Name())
- if len(matches) != 4 {
+ if matches == nil {
  continue
  }
 

pkg/spanner/migration_test.go

@@ -22,6 +22,8 @@ package spanner
 import (
  "path/filepath"
  "testing"
+
+ "github.com/stretchr/testify/assert"
 )
 
 const (
@@ -316,3 +318,38 @@ func Test_isPartitionedDMLOnly(t *testing.T) {
  })
  }
 }
+
+func Test_migrationFileRegex(t *testing.T) {
+ tests := map[string]struct {
+ input string
+ expected []string
+ }{
+ "NoName": {
+ input: "001.sql",
+ expected: []string{"001.sql", "001", ""},
+ },
+ "WithName": {
+ input: "001_name.sql",
+ expected: []string{"001_name.sql", "001", "name"},
+ },
+ "MatchAndIgnoreUp": {
+ input: "001_name.up.sql",
+ expected: []string{"001_name.up.sql", "001", "name"},
+ },
+ "MatchAndIgnoreGenerated": {
+ input: "001_name.generated.sql",
+ expected: []string{"001_name.generated.sql", "001", "name"},
+ },
+ "NotMatchDownMigration": {
+ input: "001_name.down.sql",
+ expected: nil,
+ },
+ }
+
+ for name, tc := range tests {
+ t.Run(name, func(t *testing.T) {
+ matches := migrationFileRegex.FindStringSubmatch(tc.input)
+ assert.Equal(t, tc.expected, matches)
+ })
+ }
+}