Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google api/jd #13

Merged
merged 3 commits into from
Apr 15, 2022
Merged

Google api/jd #13

merged 3 commits into from
Apr 15, 2022

Conversation

Romeslayer
Copy link
Owner

What's this PR do?

  • Creates Google Map to display to the DOM
  • Creates Markers to display on the Map
  • Adds new image to be displayed as a marker

Where should the reviewer start?

  • Maps.js and App.js to ensure that the map is being displayed.

Any background context you want to provide?

What are the relevant tickets?

N/A

Screenshots (if appropriate)

N/A

Questions:

N/A

Copy link
Collaborator

@RonLHead RonLHead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Map display looks solid. Markers on the map is a win!

Copy link
Collaborator

@zliibbe zliibbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeNaje, that's a great catch. Happy that the map is displaying as expected, good to have a map that displays and we can update the Google Map API in a future branch.

@zliibbe zliibbe merged commit 6849c57 into main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants