Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested fixes for most of the issues I reported #231

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Suggested fixes for most of the issues I reported #231

wants to merge 44 commits into from

Conversation

JBontes
Copy link

@JBontes JBontes commented Oct 3, 2017 •
edited
Loading

Note that #224 also fixes a slight issue where the SyntaxNodeNames got out of sync with the SyntaxNodeTypes (My bad). Also note that #224 allows you to put the operators anywhere in the list, as long as all operators are kept together.

Added all remaining fixes in my local version.

This concludes the list of issues for which I have an easy fix.

JBontes and others added 9 commits October 3, 2017 11:04
@JBontes
Merge pull request #1 from RomanYankovsky/master
352c20a 
Update from original
RomanYankovsky#220, RomanYankovsky#181
0df834c 
Added an explicit anKind attribute containing `type` if there is an explicit type.
RomanYankovsky#221, record type params in the name
2400ab9 
Record type params (and other parts of the name explicitly in subnodes. Still record the full name in an attribute.
RomanYankovsky#222, use the anName attribute to store names exclusively
c26af5a 
Store all names in a ntName node with a anName attribute for consistency. A name is not a value, so it should not be stored in a value property.
RomanYankovsky#223 Except else <> if else
12ca887 
An except-else has very different semantics from an if-else. It needs a specialized node type.
RomanYankovsky#226 Add support for forwarded object types
6f33800 
Both class and object can be declared forward.
RomanYankovsky#227 Labeled statement does not register
8a9b20c
RomanYankovsky#228 differentiate between const and resourcestring sec…
b7ec406 
…tion
RomanYankovsky#229 Parse object type correctly
496edbb
@RomanYankovsky
Copy link
Owner

Thank you for creating a pull request. It will save a lot of time. I'll review it as soon as possible.

jbontes added 2 commits October 3, 2017 13:34
RomanYankovsky#225, optimization: use a set to keep track of attribut…
0425ee9 
…es in use by a node
RomanYankovsky#224 Optimization fetch correct operator record in O(1)…
76e4e81 
… time

TOperators.GetItem uses a for loop to extract the correct OperatorsInfo record.
This is inefficient. If you reorder the TSyntaxNodeType enumeration so that the operators are in the same order as OperatorsInfo then we can use a simple in statement.
@JBontes JBontes changed the title Suggested fixes for issues #229, #228, #227, #226, #223, #222, #221, #220, #181 Suggested fixes for issues #229, #228, #227, #226, #223, #222, #221, #220, #181 + optimizations #224 + #225 Oct 3, 2017
RomanYankovsky#166 Forward declaration fixes
8ad0174 
Methods can be declared forward in the implementation section.
Also the semicolon after forward is optional as per Turbo Pascal legacy.
@JBontes JBontes changed the title Suggested fixes for issues #229, #228, #227, #226, #223, #222, #221, #220, #181 + optimizations #224 + #225 Suggested fixes for issues #229, #228, #227, #226, #223, #222, #221, #220, #181, #166 + optimizations #224 + #225 Oct 3, 2017
RomanYankovsky#232 SyntaxNodeNames should be automatically derived fr…
09b4d92 
…om SyntaxNodeTypes

The cool thing about this fix is that no changes are need to the rest of the code and it runs with the same performance as the old code.
@JBontes JBontes changed the title Suggested fixes for issues #229, #228, #227, #226, #223, #222, #221, #220, #181, #166 + optimizations #224 + #225 Suggested fixes for issues #229, #228, #227, #226, #223, #222, #221, #220, #181, #166, #232 + optimizations #224 + #225 Oct 3, 2017
@JBontes
Copy link
Author

JBontes commented Oct 3, 2017 •
edited
Loading

You're welcome. I'm just trying to get AST to parse all code correctly so I can use it as a macro/code rewrite tool. Unfortunately my own version has got quite a few alterations that are out of scope for DelphiAST, so I cloned a fresh version and plugged in the changes there.

@JBontes JBontes mentioned this pull request Oct 3, 2017
Open
@JBontes JBontes changed the title Suggested fixes for issues #229, #228, #227, #226, #223, #222, #221, #220, #181, #166, #232 + optimizations #224 + #225 Suggested fixes for issues #237, #236, #235, #234, #233, #232, #229, #228, #227, #226, #223, #222, #221, #220, #181, #166 + optimizations #224 + #225 Oct 3, 2017
RomanYankovsky#216 reference to anonymoustype fixed. RomanYankovsky#237…
f416308 
… resident external keyword added.

Plus a few other small fixes.
@JBontes JBontes changed the title Suggested fixes for issues #237, #236, #235, #234, #233, #232, #229, #228, #227, #226, #223, #222, #221, #220, #181, #166 + optimizations #224 + #225 Suggested fixes for issues #237, #236, #235, #234, #233, #232, #229, #228, #227, #226, #223, #222, #221, #220, #216, #181, #166 + optimizations #224 + #225 Oct 5, 2017
RomanYankovsky#230 Variant records are now supported
9226c1f 
Also included are a few minor optimizations.
@JBontes JBontes changed the title Suggested fixes for issues #237, #236, #235, #234, #233, #232, #229, #228, #227, #226, #223, #222, #221, #220, #216, #181, #166 + optimizations #224 + #225 Suggested fixes for issues #237, #236, #235, #234, #233, #232, #230, #229, #228, #227, #226, #223, #222, #221, #220, #216, #181, #166 + optimizations #224 + #225 Oct 6, 2017
@JBontes JBontes changed the title Suggested fixes for issues #237, #236, #235, #234, #233, #232, #230, #229, #228, #227, #226, #223, #222, #221, #220, #216, #181, #166 + optimizations #224 + #225 Suggested fixes for issues #243, #242, #237, #236, #235, #234, #233, #232, #230, #229, #228, #227, #226, #223, #222, #221, #220, #216, #181, #166 + optimizations #224 + #225 Oct 12, 2017
jbontes added 6 commits October 13, 2017 16:19
Fix for RomanYankovsky#246 varargs, RomanYankovsky#245 proc of object, …
cfa5cc3 
…RomanYankovsky#244 automated section
Fix for RomanYankovsky#62, RomanYankovsky#247 hinting directives
21d2872
RomanYankovsky#248 static methodbinding
5e64775
RomanYankovsky#249 assembler inline directive
5c34b3d
RomanYankovsky#248 static + 249 assembler inline directive
8ae51f0
RomanYankovsky#250 record constants are not recorded correctly
6d60707 
This is esp. evident in the following example:
const
  OperatorsInfo: array [0..2] of TOperatorInfo =
    ((Typ: ntAddr;         AssocType: atRight),
     (Typ: ntDeref;        AssocType: atLeft),
     (Typ: ntGeneric;      AssocType: atRight));

All constants are incorrectly listed as one long list, instead of as separate records.
@JBontes JBontes changed the title Suggested fixes for issues #243, #242, #237, #236, #235, #234, #233, #232, #230, #229, #228, #227, #226, #223, #222, #221, #220, #216, #181, #166 + optimizations #224 + #225 Suggested fixes for most of the issues I reported Oct 15, 2017
jbontes and others added 18 commits October 16, 2017 12:43
RomanYankovsky#251 Also parse programs, libs and packages
7ef300f
RomanYankovsky#252 record compiler directive
468a2be
RomanYankovsky#35 More capable {$IF ... } handling
602e980 
It can parse arbitrarily complex expressions and also deal with more complex comparisons and floating point numbers.
RomanYankovsky#252 do not register compiler directives, unless the co…
e89593a 
…mpiler can see them
RomanYankovsky#253 support absolute and RomanYankovsky#252 part2
23637da
RomanYankovsky#252 always put compiler directive underneigh the root
0f89a62
RomanYankovsky#254 Error in parsing anonymous methods
5fcd93f
RomanYankovsky#255 Treat array of const correctly
bbbe2e2 
array of const is a special construct. `const` here is not an identifier.
RomanYankovsky#35 add processing for isdeclared and fix endless loop
793b098
RomanYankovsky#217 Record const [ref] atrtribute
1a15887
RomanYankovsky#256 Record @@ casting (for procedural variables)
a8ad741 
Added `@@` as a distinct operator.
RomanYankovsky#257 inline asm statements are not recorded
0679a5f
RomanYankovsky#257 small refinements.
644161a
RomanYankovsky#258 type safe TOperators. RomanYankovsky#217 fix cor…
1e3101d 
…ruption of childnode list.
RomanYankovsky#258 minor tweak
3f8415e
RomanYankovsky#227 correct label processing, RomanYankovsky#217 Fix b…
959fe23 
…ug in parameter processing introduced in the original 217 fix
minor optimizations
c888a89
@JBontes
Merge branch 'master' into master
84a28d4
@JBontes
Copy link
Author

JBontes commented Nov 2, 2018

I'll review it as soon as possible.

I fixed the conflict, have you had time to look at it yet?
No rush :-)

@alex-ilin
Copy link

alex-ilin commented Jun 1, 2021 •
edited
Loading

@RomanYankovsky, will you review the PR already? The suspense is killing me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JBontes @RomanYankovsky @alex-ilin