Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/update-deps 2024-04-26 #74

Merged
merged 10 commits into from
Apr 28, 2024

Conversation

FaberVitale
Copy link
Collaborator

@FaberVitale FaberVitale commented Apr 26, 2024

Description

Dependencies updates

  • Updates pnpm, astro, solid-js, vitest, typescript, @astrojs/sitemap, tiny-invariant to latest.
  • Removes unused dependencies 971949c.

Pipeline changes

  • Run corepack enable before installing dependencies. 000ac42
  • Log node & pnpm version 000ac42

Lint

  • Fixes lint:astro (astro check) silently failing in CI 58a3efd
  • Fixes lint issues reported by astro check 58a3efd
  • Run astro check && tsc --noEmit on precommit 5cbd26d
Misc

Use node: when importing builtin node modules e87b8e9

Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for romajs ready!

Name Link
🔨 Latest commit effbaa0
🔍 Latest deploy log https://app.netlify.com/sites/romajs/deploys/662b77d3075b070008fcf763
😎 Deploy Preview https://deploy-preview-74--romajs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FaberVitale FaberVitale requested a review from gdorsi April 26, 2024 09:48
@@ -0,0 +1,6 @@
export default {
'*.{js,jsx,ts,tsx,json,css,scss,sass,md,yml,yaml,cjs,mjs,cts,mts,html,htm,babelrc}':
'prettier --write',
Copy link
Contributor

@gdorsi gdorsi Apr 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to experiment a bit here and try out:

  • biome for formatting and linting
  • lefthook for git hooks (should be faster than lintstaged)

Speed doesn't matter much in a project of this size, but curious to see if these solutions are really production ready.

WDYT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can definitely take a look at them and test the integration in a PR.

If there are no major issues we can definitely use them.

@FaberVitale FaberVitale merged commit 436b262 into Roma-JS:main Apr 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants