Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump apexcharts #784

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nukesor
Copy link

@Nukesor Nukesor commented Oct 6, 2024

Hey @RomRider :)

First of all, thanks a lot for this library!

Apexcharts released a few new versions, which include some critical bugfixes and improvements for their multi-y-axis setups.
https://github.com/apexcharts/apexcharts.js/releases

As far as I can see, there're no changes in their API, so this should be a fairly quick and safe update.

It would be awesome if you could merge this and release a new patch release :)

Thanks in advance!

@pfiorentino
Copy link

Hey!
Thanks for the PR ❤️

Just a quick question, wouldn't it be better to bump the package directly in the package.json instead of the package-lock.json?
The package-lock.json should follow 🙂

Side note: apexcharts 3.54.1 is now out with more fixes! 🎉

@Nukesor
Copy link
Author

Nukesor commented Oct 25, 2024

Hey! Thanks for the PR ❤️

Just a quick question, wouldn't it be better to bump the package directly in the package.json instead of the package-lock.json? The package-lock.json should follow 🙂

Side note: apexcharts 3.54.1 is now out with more fixes! 🎉

Will do that.
^3.50.0 also allows miner/patch version bumps, so I didn't really mind as the lockfile determines the version in the end. I usually have ^3 in my own dependency declarations as long as the dependency complies with semver. 😁

@pfiorentino
Copy link

Hey! Thanks for the PR ❤️
Just a quick question, wouldn't it be better to bump the package directly in the package.json instead of the package-lock.json? The package-lock.json should follow 🙂
Side note: apexcharts 3.54.1 is now out with more fixes! 🎉

Will do that. ^3.50.0 also allows miner/patch version bumps, so I didn't really mind as the lockfile determines the version in the end. I usually have ^3 in my own dependency declarations as long as the dependency complies with semver. 😁

Totally second that 😊

I just had a look at how @RomRider usually bump dependencies in his repo.
And apparently he use to fix the version in the package.json and let npm do its job with the package-lock.json.
Hence my message.

But 100% agreed that it would have worked perfectly with your first suggestion 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants