-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Preview2D Panel UI/UX #707
Open
Jowan-Spooner
wants to merge
32
commits into
RodZill4:master
Choose a base branch
from
Jowan-Spooner:better-preview-panels
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enhanced Preview2D Panel UI/UX #707
Jowan-Spooner
wants to merge
32
commits into
RodZill4:master
from
Jowan-Spooner:better-preview-panels
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jowan-Spooner
commented
Sep 4, 2024
•
edited
Loading
edited
This is done by assigning a "result_quality" score to each item based on how it matched. In the Add Node Panel this is used to sort the results.
This makes it so clicking on one of the Library panels "Section" buttons (e.g. Simple, 3D, Noise) will scroll far enough to have that item at the TOP of the tree, not just barely visible.
Remove prints, add tooltip
Implements a "Lock" button in the preview menu. Adds new icons (added as png for now, svg should be used in the future, but there are some bugs in ThorVG). Also does a bunch of changes to make sure the preview is cleared when a node is deleted.
Makes sure Preview-Controls get cleared when node get's deleted. Removes old export code. Makes default fallback shader transparent instead of black.
- Wrap Pixel Colors Buttons at 8 - make panels toplevel (to not make them cutof when panel is to small) - move ComplexParamter to menu bar
- Buttons inside of menu panels can now be activated even if the panel isn't open. This is currently only relevant for CTRL+R (center view) CTRL+E (export image) However this code also already improves how OptionEdits handle shortcuts (they iterate through instead of opening). More shortcuts could be added although in a perfect world we had some system to customize shortcuts.
Sorry, it was just to simple to exclude 🙈
Now mentions the file name in the folder selection window when exporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.