Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in signature V4 method and update test case #6

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

iMac0de
Copy link
Contributor

@iMac0de iMac0de commented Jan 29, 2018

No description provided.

@RockfordWei
Copy link
Owner

I checked out your branch but the testing reported on testSign() but succeded on testSample():

XCTAssertEqual failed: ("a59369a9c5c0cb3b5fc34e5ef689de2bc6cfb6e1ee2ada35c6def5bb35a1da9f") is not equal to ("6b555ea915ec8a5ee592ccfeec21a4d8d0ee27cfb29c8349fd80118f462ec23b") - 

May I ask why? A bit confused.

@iMac0de
Copy link
Contributor Author

iMac0de commented Jan 31, 2018

In fact, the new V4 signature take in account the bucket name. AWS S3 accept only unique bucket name, so I couldn't create a bucket named fishpool and make the test with another bucket name. I think this why the assert equal is failing.

However, it allows me to fix a little issue on the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants