Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: flight comparison improvements #755

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

Gui-FernandesBR
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR commented Dec 15, 2024

Pull request type

  • ReadMe, Docs and GitHub updates

Checklist

  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Matplotlib is great, but plotly... Well, plotly is a masterpiece!

New behavior

image

When hovering...
image

Breaking change

  • No

Additional information

@phmbressan could you pip compile the docs/requirements.txt this again please? I would not like cloning the repo to linux again.

@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner December 15, 2024 02:49
@Gui-FernandesBR Gui-FernandesBR force-pushed the docs/flight-comparison-improvements branch from 1a6c41f to ab8053f Compare December 15, 2024 02:51
Copy link
Contributor

@LUCKIN13 LUCKIN13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plotly does indeed look great.
LGTM

Gui-FernandesBR and others added 4 commits December 15, 2024 23:42
Update flight simulation documentation with improved markdown headers and replace matplotlib with Plotly for enhanced visualizations
@Gui-FernandesBR Gui-FernandesBR force-pushed the docs/flight-comparison-improvements branch from 41b6a49 to 0f4af95 Compare December 16, 2024 02:42
@Gui-FernandesBR Gui-FernandesBR merged commit ed6af68 into develop Dec 16, 2024
1 check passed
@Gui-FernandesBR Gui-FernandesBR deleted the docs/flight-comparison-improvements branch December 16, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants