Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Updates master for v1.7.1 #749

Merged
merged 5 commits into from
Dec 7, 2024
Merged

DEV: Updates master for v1.7.1 #749

merged 5 commits into from
Dec 7, 2024

Conversation

phmbressan
Copy link
Collaborator

Pull request type

  • Other (please describe): Master update

Breaking change

  • Yes
  • No

phmbressan and others added 5 commits November 30, 2024 14:32
* MNT: Add CAD data for tank geometry validation.

* MNT: Refactor tank testing and improve file structure.

* STY: fix pylint suggestions.

* ENH: implement Tanks prints and plots.

* MNT: add recent changes to CHANGELOG.

* TST: tighten tolerances for tank geometry tests.

* DOC: improve description of cad notebook validator.

* MNT: remove duplicated fixtures.

* DOC: improve flux_time docstring description.

* MNT: add info and all_info methods to tanks.

---------

Co-authored-by: Gui-FernandesBR <[email protected]>
BUG: Correctly update atmospheric conditions after changing date and location
@phmbressan phmbressan added the Releases Related with new releases label Dec 7, 2024
@phmbressan phmbressan added this to the Release v1.X.0 milestone Dec 7, 2024
@phmbressan phmbressan self-assigned this Dec 7, 2024
@phmbressan phmbressan requested a review from a team as a code owner December 7, 2024 09:46
@phmbressan phmbressan merged commit 25fcf17 into master Dec 7, 2024
8 checks passed
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 96.90722% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.43%. Comparing base (9761e74) to head (ed2a6a2).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
rocketpy/plots/tank_geometry_plots.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #749      +/-   ##
==========================================
+ Coverage   75.97%   76.43%   +0.46%     
==========================================
  Files          95       95              
  Lines       11027    11078      +51     
==========================================
+ Hits         8378     8468      +90     
+ Misses       2649     2610      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Releases Related with new releases
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants