-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: move piecewise functions to separate file #746
MNT: move piecewise functions to separate file #746
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #746 +/- ##
===========================================
+ Coverage 76.42% 76.47% +0.05%
===========================================
Files 95 96 +1
Lines 11090 11094 +4
===========================================
+ Hits 8475 8484 +9
+ Misses 2615 2610 -5 ☔ View full report in Codecov by Sentry. |
@Gui-FernandesBR and @phmbressan, besides applying the code formaters and creating the tests, I simplified and optimized just a bit the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging, the CHANGELOG should be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #667
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
Enter text here...
New behavior
Enter text here...
Breaking change
Additional information
Enter text here...