Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: move piecewise functions to separate file #746

Conversation

yogirajgutte
Copy link

@yogirajgutte yogirajgutte commented Dec 5, 2024

closes #667

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Enter text here...

New behavior

Enter text here...

Breaking change

  • Yes
  • No

Additional information

Enter text here...

@yogirajgutte yogirajgutte requested a review from a team as a code owner December 5, 2024 20:30
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.47%. Comparing base (83aa20e) to head (a997774).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #746      +/-   ##
===========================================
+ Coverage    76.42%   76.47%   +0.05%     
===========================================
  Files           95       96       +1     
  Lines        11090    11094       +4     
===========================================
+ Hits          8475     8484       +9     
+ Misses        2615     2610       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lucas-Prates Lucas-Prates changed the base branch from master to develop December 14, 2024 21:31
@Lucas-Prates
Copy link
Contributor

Lucas-Prates commented Dec 15, 2024

@Gui-FernandesBR and @phmbressan, besides applying the code formaters and creating the tests, I simplified and optimized just a bit the PiecewiseFunction class. If you can, please take a very quick glance just to make sure it LGTY.

Copy link
Collaborator

@phmbressan phmbressan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, the CHANGELOG should be updated.

rocketpy/mathutils/piecewise_function.py Outdated Show resolved Hide resolved
rocketpy/mathutils/piecewise_function.py Outdated Show resolved Hide resolved
rocketpy/mathutils/piecewise_function.py Outdated Show resolved Hide resolved
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gui-FernandesBR Gui-FernandesBR merged commit 2218f0f into RocketPy-Team:develop Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

MNT: Move the Piecewise function to a separate module
4 participants