Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Implementing Multivariate Rejection Sampling (MRS) in RocketPy #738

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

MNT: refactoring class to match review suggestions

3a3c9e6
Select commit
Loading
Failed to load commit list.
Draft

ENH: Implementing Multivariate Rejection Sampling (MRS) in RocketPy #738

MNT: refactoring class to match review suggestions
3a3c9e6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 20, 2024 in 1s

75.92% (-0.50%) compared to 83aa20e

View this Pull Request on Codecov

75.92% (-0.50%) compared to 83aa20e

Details

Codecov Report

Attention: Patch coverage is 17.30769% with 86 lines in your changes missing coverage. Please review.

Project coverage is 75.92%. Comparing base (83aa20e) to head (3a3c9e6).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...ketpy/simulation/multivariate_rejection_sampler.py 17.30% 86 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #738      +/-   ##
===========================================
- Coverage    76.42%   75.92%   -0.50%     
===========================================
  Files           95       97       +2     
  Lines        11090    11198     +108     
===========================================
+ Hits          8475     8502      +27     
- Misses        2615     2696      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.