BUG: forecast and reanalysis models - move wind_speed to correct position #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #735 +/- ##
===========================================
- Coverage 75.99% 75.96% -0.04%
===========================================
Files 95 95
Lines 11015 11022 +7
===========================================
+ Hits 8371 8373 +2
- Misses 2644 2649 +5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Gui-FernandesBR
force-pushed
the
master
branch
from
12efaf2 to
41d2e6b
Compare
Gui-FernandesBR
changed the title
…o pr/WilliamArmst/735
Gui-FernandesBR
approved these changes
Nov 23, 2024
There was a problem hiding this comment.
This was an amazing catch.
@WilliamArmst thank you so much for your contribution!
5 tasks
Gui-FernandesBR
added a commit
that referenced
this pull request
Nov 23, 2024
…ables dictionary (#736) * forecast_reanalysis - move wind_speed to correct position * forecast_reanalysis - move wind_speed to correct position * DEV: adds #735 to CHANGELOG * update ECMWF dictionary values * allow depreciated .nc files * allow .nc files with only one time variable * TST? parameterize acceptance test for NDRT 2020 rocket data with multiple environment files * STY: apply black --------- Co-authored-by: Gui-FernandesBR <[email protected]> Co-authored-by: Gui-FernandesBR <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bugfix
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCurrent behavior
Using ERA5 Reanalysis weather data, the wind speed function was in the incorrect position. See line 1899, where the
__set_wind_speed_functionreferencesdata_array[7]for the wind speed.New behavior
Wind speed is now calculated correctly.
Breaking change
Additional information
N/A