-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Faraday 2023 flight sim #734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice addition. I have a few comments to share:
-
Can you check with the team (maybe reading their technical report) if you could improve the drag curves at least by adding a few more points? Even openrocket drag curve would already be beneficial to us. A constant value is not really helping here.
-
Also, the altitude of ejection of the main parachute seems to not be right. Any chance this value was different?
-
Please add the new flight to the
https://docs.rocketpy.org/en/latest/examples/index.html
page. -
As Faraday is a team and not a rocket, I'm afraid we should change the name of the folder you have created. Probably this will not be the last rocket from faraday that we add to our docs.
Thanks @Gui-FernandesBR for your review. Valid points, almost totally fixed. |
Understood. I noticed the power_on drag is higher than the power_off drag. It should be the opposite tho. |
@Gui-FernandesBR just went with the higher value in drag. 30 meters reduction, and I believe that since is a constant drag, it's difficult to reach better results. This can be updated later, if the team gives us more data. |
Great work. That's what I expected. Off-topic, I believe GitHub has solved a long-known-issue which is the notebook diffs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, another amazing example added to our docs!
@LUCKIN13 go ahead and merge this PR.
I recommend using the Squash and merge option since the PR had several adjustment commits.
You have done an amazing job here.
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Additional information
This branch still needs some data reviews since the simulation file was developed in an older version of RocketPy. However, reviews can already be made, since the example should only suffer minor changes, if needed.
Changelog and Index for examples will be updated in other flight example, to prevent conflicts.